aboutsummaryrefslogtreecommitdiff
path: root/run_unittests.py
diff options
context:
space:
mode:
authorJussi Pakkanen <jpakkane@gmail.com>2021-01-12 21:51:19 +0200
committerJussi Pakkanen <jpakkane@gmail.com>2021-01-19 20:25:55 +0000
commit8133a7b9a4b8f0686fbc479aa2d64e41c85a979b (patch)
tree6d92574c0b8518e01e5447b3883a8fe3c5d00990 /run_unittests.py
parentc64d4070763b2daf82a50a7b4f5b130b2bb91062 (diff)
downloadmeson-8133a7b9a4b8f0686fbc479aa2d64e41c85a979b.zip
meson-8133a7b9a4b8f0686fbc479aa2d64e41c85a979b.tar.gz
meson-8133a7b9a4b8f0686fbc479aa2d64e41c85a979b.tar.bz2
Keep buildtype the same even if user changes debug and/or optimization.
Diffstat (limited to 'run_unittests.py')
-rwxr-xr-xrun_unittests.py44
1 files changed, 3 insertions, 41 deletions
diff --git a/run_unittests.py b/run_unittests.py
index c89b822..3ad0a7e 100755
--- a/run_unittests.py
+++ b/run_unittests.py
@@ -3929,51 +3929,13 @@ class AllPlatformTests(BasePlatformTests):
self.setconf('-Ddebug=false')
opts = self.get_opts_as_dict()
self.assertEqual(opts['debug'], False)
- self.assertEqual(opts['buildtype'], 'plain')
+ self.assertEqual(opts['buildtype'], 'debug')
self.assertEqual(opts['optimization'], '0')
-
- # Setting optimizations to 3 should cause buildtype
- # to go to release mode.
- self.setconf('-Doptimization=3')
+ self.setconf('-Doptimization=g')
opts = self.get_opts_as_dict()
- self.assertEqual(opts['buildtype'], 'release')
self.assertEqual(opts['debug'], False)
- self.assertEqual(opts['optimization'], '3')
-
- # Going to debug build type should reset debugging
- # and optimization
- self.setconf('-Dbuildtype=debug')
- opts = self.get_opts_as_dict()
self.assertEqual(opts['buildtype'], 'debug')
- self.assertEqual(opts['debug'], True)
- self.assertEqual(opts['optimization'], '0')
-
- # Command-line parsing of buildtype settings should be the same as
- # setting with `meson configure`.
- #
- # Setting buildtype should set optimization/debug
- self.new_builddir()
- self.init(testdir, extra_args=['-Dbuildtype=debugoptimized'])
- opts = self.get_opts_as_dict()
- self.assertEqual(opts['debug'], True)
- self.assertEqual(opts['optimization'], '2')
- self.assertEqual(opts['buildtype'], 'debugoptimized')
- # Setting optimization/debug should set buildtype
- self.new_builddir()
- self.init(testdir, extra_args=['-Doptimization=2', '-Ddebug=true'])
- opts = self.get_opts_as_dict()
- self.assertEqual(opts['debug'], True)
- self.assertEqual(opts['optimization'], '2')
- self.assertEqual(opts['buildtype'], 'debugoptimized')
- # Setting both buildtype and debug on the command-line should work, and
- # should warn not to do that. Also test that --debug is parsed as -Ddebug=true
- self.new_builddir()
- out = self.init(testdir, extra_args=['-Dbuildtype=debugoptimized', '--debug'])
- self.assertRegex(out, 'Recommend using either.*buildtype.*debug.*redundant')
- opts = self.get_opts_as_dict()
- self.assertEqual(opts['debug'], True)
- self.assertEqual(opts['optimization'], '2')
- self.assertEqual(opts['buildtype'], 'debugoptimized')
+ self.assertEqual(opts['optimization'], 'g')
@skipIfNoPkgconfig
@unittest.skipIf(is_windows(), 'Help needed with fixing this test on windows')