diff options
author | Dylan Baker <dylan@pnwbakers.com> | 2021-08-31 09:55:01 -0700 |
---|---|---|
committer | Eli Schwartz <eschwartz93@gmail.com> | 2021-08-31 16:28:54 -0400 |
commit | 4d7031437c7a81b52c776d4ae1e32741bdb851ca (patch) | |
tree | 7716c4af0d3f43b450a7c94dd42ae5dbef8ebdff /mesonbuild/mparser.py | |
parent | 06fdb29daace9ebe55e5df5336f65cba304773d2 (diff) | |
download | meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.zip meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.tar.gz meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.tar.bz2 |
pylint: turn on superflous-parens
We have a lot of these. Some of them are harmless, if unidiomatic, such
as `if (condition)`, others are potentially dangerous `assert(...)`, as
`assert(condtion)` works as expected, but `assert(condition, message)`
will result in an assertion that never triggers, as what you're actually
asserting is `bool(tuple[2])`, which will always be true.
Diffstat (limited to 'mesonbuild/mparser.py')
-rw-r--r-- | mesonbuild/mparser.py | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/mesonbuild/mparser.py b/mesonbuild/mparser.py index 1617dd1..c470e29 100644 --- a/mesonbuild/mparser.py +++ b/mesonbuild/mparser.py @@ -406,28 +406,28 @@ class MethodNode(BaseNode): super().__init__(lineno, colno, filename) self.source_object = source_object # type: BaseNode self.name = name # type: str - assert(isinstance(self.name, str)) + assert isinstance(self.name, str) self.args = args # type: ArgumentNode class FunctionNode(BaseNode): def __init__(self, filename: str, lineno: int, colno: int, end_lineno: int, end_colno: int, func_name: str, args: ArgumentNode): super().__init__(lineno, colno, filename, end_lineno=end_lineno, end_colno=end_colno) self.func_name = func_name # type: str - assert(isinstance(func_name, str)) + assert isinstance(func_name, str) self.args = args # type: ArgumentNode class AssignmentNode(BaseNode): def __init__(self, filename: str, lineno: int, colno: int, var_name: str, value: BaseNode): super().__init__(lineno, colno, filename) self.var_name = var_name # type: str - assert(isinstance(var_name, str)) + assert isinstance(var_name, str) self.value = value # type: BaseNode class PlusAssignmentNode(BaseNode): def __init__(self, filename: str, lineno: int, colno: int, var_name: str, value: BaseNode): super().__init__(lineno, colno, filename) self.var_name = var_name # type: str - assert(isinstance(var_name, str)) + assert isinstance(var_name, str) self.value = value # type: BaseNode class ForeachClauseNode(BaseNode): @@ -727,7 +727,7 @@ class Parser: def method_call(self, source_object: BaseNode) -> MethodNode: methodname = self.e9() - if not(isinstance(methodname, IdNode)): + if not isinstance(methodname, IdNode): raise ParseException('Method name must be plain id', self.getline(), self.current.lineno, self.current.colno) assert isinstance(methodname.value, str) |