aboutsummaryrefslogtreecommitdiff
path: root/mesonbuild/modules
diff options
context:
space:
mode:
authorDylan Baker <dylan@pnwbakers.com>2021-01-12 11:31:25 -0800
committerDylan Baker <dylan@pnwbakers.com>2021-01-13 13:32:48 -0800
commite36aca42d0980ce4b43e5753d798c986135e9f43 (patch)
treebe24e9dca9f08196ac83dfffa5d6b6aef9d6e026 /mesonbuild/modules
parent59328aba2929b969a7e7ce1390d891dafe391a7f (diff)
downloadmeson-e36aca42d0980ce4b43e5753d798c986135e9f43.zip
meson-e36aca42d0980ce4b43e5753d798c986135e9f43.tar.gz
meson-e36aca42d0980ce4b43e5753d798c986135e9f43.tar.bz2
build/interpreter: Split InstallDir to fix layering violation
Currently InstallDir is part of the interpreter, and is an Interpreter object, which is then put in the Build object. This is a layering violation, the interperter should have a Holder for build data. This patch fixes that.
Diffstat (limited to 'mesonbuild/modules')
-rw-r--r--mesonbuild/modules/unstable_external_project.py18
1 files changed, 9 insertions, 9 deletions
diff --git a/mesonbuild/modules/unstable_external_project.py b/mesonbuild/modules/unstable_external_project.py
index 809b590..1604e25 100644
--- a/mesonbuild/modules/unstable_external_project.py
+++ b/mesonbuild/modules/unstable_external_project.py
@@ -22,7 +22,7 @@ from ..mesonlib import (MesonException, Popen_safe, MachineChoice,
get_variable_regex, do_replacement)
from ..interpreterbase import InterpreterObject, InterpreterException, FeatureNew
from ..interpreterbase import stringArgs, permittedKwargs
-from ..interpreter import Interpreter, DependencyHolder, InstallDir
+from ..interpreter import Interpreter, DependencyHolder, InstallDirHolder
from ..compilers.compilers import CFLAGS_MAPPING, CEXE_MAPPING
from ..dependencies.base import InternalDependency, PkgConfigDependency
from ..environment import Environment
@@ -192,15 +192,15 @@ class ExternalProject(InterpreterObject):
self.subproject,
target_kwargs)
- idir = InstallDir(self.subdir.as_posix(),
- Path('dist', self.rel_prefix).as_posix(),
- install_dir='.',
- install_mode=None,
- exclude=None,
- strip_directory=True,
- from_source_dir=False)
+ idir = build.InstallDir(self.subdir.as_posix(),
+ Path('dist', self.rel_prefix).as_posix(),
+ install_dir='.',
+ install_mode=None,
+ exclude=None,
+ strip_directory=True,
+ from_source_dir=False)
- return [self.target, idir]
+ return [self.target, InstallDirHolder(idir)]
@stringArgs
@permittedKwargs({'subdir'})