diff options
| author | Jon Turney <jon.turney@dronecode.org.uk> | 2018-07-05 19:08:04 +0100 |
|---|---|---|
| committer | Nirbheek Chauhan <nirbheek.chauhan@gmail.com> | 2018-07-05 18:08:04 +0000 |
| commit | b387ab1ee14915dc3d7a302a55f2a1b96f7615a8 (patch) | |
| tree | 670c945ac5e3ee2b458e77a40cea94e286442562 /mesonbuild/modules/gnome.py | |
| parent | 8893d03703affb0f8ae66fae84aa779a7992d86c (diff) | |
| download | meson-b387ab1ee14915dc3d7a302a55f2a1b96f7615a8.zip meson-b387ab1ee14915dc3d7a302a55f2a1b96f7615a8.tar.gz meson-b387ab1ee14915dc3d7a302a55f2a1b96f7615a8.tar.bz2 | |
Fix flake8 issues (#3834)
* Fix flake8 whitespace reports
$ flake8 | grep -E '(E203|E221|E226|E303|W291|W293)'
./mesonbuild/coredata.py:337:5: E303 too many blank lines (2)
* Fix flake8 'variable assigned value but unused' reports
$ flake8 | grep -E F841
./mesonbuild/modules/gnome.py:922:9: F841 local variable 'target_name' is assigned to but never used
* Fix flake8 'imported but unused' reports
$ flake8 | grep F401
./mesonbuild/compilers/__init__.py:128:1: F401 '.c.ArmclangCCompiler' imported but unused
./mesonbuild/compilers/__init__.py:138:1: F401 '.cpp.ArmclangCPPCompiler' imported but unused
./mesonbuild/modules/__init__.py:4:1: F401 '..mlog' imported but unused
PR #3717 imports ARMCLANG compilers in __init__, but does not add them to
__all__, so they are not re-exported by the compilers package like
everything else.
* More details about flake8 in Contributing.md
Mention that Sider runs flake8
Suggest seting flake8 as a pre-commit hook
Diffstat (limited to 'mesonbuild/modules/gnome.py')
| -rw-r--r-- | mesonbuild/modules/gnome.py | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/mesonbuild/modules/gnome.py b/mesonbuild/modules/gnome.py index fabb0f9..f2c5b2d 100644 --- a/mesonbuild/modules/gnome.py +++ b/mesonbuild/modules/gnome.py @@ -919,7 +919,6 @@ This will become a hard error in the future.''') raise MesonException('gdbus_codegen takes at most two arguments, name and xml file.') namebase = args[0] xml_files = args[1:] - target_name = namebase + '-gdbus' cmd = [self.interpreter.find_program_impl('gdbus-codegen')] extra_args = mesonlib.stringlistify(kwargs.pop('extra_args', [])) cmd += extra_args |