diff options
author | Xavier Claessens <xavier.claessens@collabora.com> | 2020-05-06 14:10:42 -0400 |
---|---|---|
committer | Nirbheek Chauhan <nirbheek.chauhan@gmail.com> | 2020-05-14 17:59:17 +0000 |
commit | 93dc9cfcc3ef946680ebe4724977c4b93ffa4a0f (patch) | |
tree | 938d4780eaf2b000b3a1ea271fe6cc0f790c7f98 /mesonbuild/modules/gnome.py | |
parent | 3e134975749b67b8c799a8b8fd065721de1cb48a (diff) | |
download | meson-93dc9cfcc3ef946680ebe4724977c4b93ffa4a0f.zip meson-93dc9cfcc3ef946680ebe4724977c4b93ffa4a0f.tar.gz meson-93dc9cfcc3ef946680ebe4724977c4b93ffa4a0f.tar.bz2 |
gnome.generate_gir: Fix missing include directories
This revert a part of #7020 because it was using gir_inc_dirs
before it is set. Properly fix typelib_includes instead that was working
only when g-i is a pkgconfig dependency.
Diffstat (limited to 'mesonbuild/modules/gnome.py')
-rw-r--r-- | mesonbuild/modules/gnome.py | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/mesonbuild/modules/gnome.py b/mesonbuild/modules/gnome.py index a97fffa..01acb37 100644 --- a/mesonbuild/modules/gnome.py +++ b/mesonbuild/modules/gnome.py @@ -695,11 +695,10 @@ class GnomeModule(ExtensionModule): source.get_subdir()) if subdir not in typelib_includes: typelib_includes.append(subdir) - elif isinstance(dep, PkgConfigDependency): - girdir = dep.get_pkgconfig_variable("girdir", {'default': ''}) + if isinstance(dep, Dependency): + girdir = dep.get_variable(pkgconfig='girdir', internal='girdir', default_value='') if girdir and girdir not in typelib_includes: typelib_includes.append(girdir) - return typelib_includes def _get_external_args_for_langs(self, state, langs): @@ -769,7 +768,6 @@ class GnomeModule(ExtensionModule): external_ldflags += list(self._get_scanner_ldflags(dep_external_ldflags)) girtargets_inc_dirs = self._get_gir_targets_inc_dirs(girtargets) inc_dirs = self._scan_inc_dirs(kwargs) - gi_includes.update(gir_inc_dirs + inc_dirs) scan_command = [giscanner] scan_command += ['--no-libtool'] @@ -790,7 +788,7 @@ class GnomeModule(ExtensionModule): scan_command += cflags scan_command += ['--cflags-end'] scan_command += get_include_args(inc_dirs) - scan_command += get_include_args(list(gi_includes), prefix='--add-include-path=') + scan_command += get_include_args(list(gi_includes) + gir_inc_dirs + inc_dirs, prefix='--add-include-path=') scan_command += list(internal_ldflags) scan_command += self._scan_gir_targets(state, girtargets) scan_command += self._scan_langs(state, [lc[0] for lc in langs_compilers]) @@ -804,7 +802,7 @@ class GnomeModule(ExtensionModule): typelib_output = '%s-%s.typelib' % (ns, nsversion) typelib_cmd = [gicompiler, scan_target, '--output', '@OUTPUT@'] - typelib_cmd += get_include_args(list(gi_includes), prefix='--includedir=') + typelib_cmd += get_include_args(gir_inc_dirs, prefix='--includedir=') for incdir in typelib_includes: typelib_cmd += ["--includedir=" + incdir] |