diff options
| author | Nirbheek Chauhan <nirbheek@centricular.com> | 2020-07-01 06:52:56 +0530 |
|---|---|---|
| committer | Jussi Pakkanen <jpakkane@gmail.com> | 2020-07-05 16:13:00 +0300 |
| commit | 40319c963447f7632753e694f606dc6d41a9f168 (patch) | |
| tree | 9e7a316efc3646df971acaa27b12d7a83e170d65 /mesonbuild/mlog.py | |
| parent | 99e96133c83aa61ab39c3d35c3248ca05fdb7ada (diff) | |
| download | meson-40319c963447f7632753e694f606dc6d41a9f168.zip meson-40319c963447f7632753e694f606dc6d41a9f168.tar.gz meson-40319c963447f7632753e694f606dc6d41a9f168.tar.bz2 | |
Don't make unactionable warnings fatal
Some warnings are out of the user's control, such as the RCC QT bug,
or the GNU windres bug, or our informational warning about
auto-disabling of options when -Db_bitcode is enabled.
Such warnings should not be fatal when --fatal-meson-warnings is
passed because there's no action that the user can take to fix it. The
only purpose it serves is to prevent people who use those features
from using --fatal-meson-warnings.
Diffstat (limited to 'mesonbuild/mlog.py')
| -rw-r--r-- | mesonbuild/mlog.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mesonbuild/mlog.py b/mesonbuild/mlog.py index 7b8aec7..1e5a105 100644 --- a/mesonbuild/mlog.py +++ b/mesonbuild/mlog.py @@ -250,7 +250,7 @@ def get_error_location_string(fname: str, lineno: str) -> str: return '{}:{}:'.format(fname, lineno) def _log_error(severity: str, *rargs: T.Union[str, AnsiDecorator], - once: bool = False, **kwargs: T.Any) -> None: + once: bool = False, fatal: bool = True, **kwargs: T.Any) -> None: from .mesonlib import MesonException, relpath # The typing requirements here are non-obvious. Lists are invariant, @@ -283,7 +283,7 @@ def _log_error(severity: str, *rargs: T.Union[str, AnsiDecorator], global log_warnings_counter log_warnings_counter += 1 - if log_fatal_warnings: + if log_fatal_warnings and fatal: raise MesonException("Fatal warnings enabled, aborting") def error(*args: T.Union[str, AnsiDecorator], **kwargs: T.Any) -> None: |