diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2022-09-02 14:43:12 -0700 |
|---|---|---|
| committer | Xavier Claessens <xclaesse@gmail.com> | 2022-09-22 18:17:43 -0400 |
| commit | f5283dd63fc40211a935330973a69aa8105aa920 (patch) | |
| tree | c3ea862cb3d08ffcbe8ddaea9d70a42d6ee445de /mesonbuild/mlog.py | |
| parent | 3ef332e89a7050d0c03801099a0649e00c187278 (diff) | |
| download | meson-f5283dd63fc40211a935330973a69aa8105aa920.zip meson-f5283dd63fc40211a935330973a69aa8105aa920.tar.gz meson-f5283dd63fc40211a935330973a69aa8105aa920.tar.bz2 | |
pylint: enable global-statement
This does force a number of uses of `# pylint: disable` comments, but it
also finds a couple of useless global uses and one place (in the
previous commit) that an easy refactor removes the use of global. Global
is a code smell, so forcing adding a comment to disable helps force
developers to really consider if what they're doing is a good idea.
Diffstat (limited to 'mesonbuild/mlog.py')
| -rw-r--r-- | mesonbuild/mlog.py | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/mesonbuild/mlog.py b/mesonbuild/mlog.py index 1bdc1ca..452b693 100644 --- a/mesonbuild/mlog.py +++ b/mesonbuild/mlog.py @@ -85,33 +85,33 @@ log_warnings_counter = 0 # type: int log_pager: T.Optional['subprocess.Popen'] = None def disable() -> None: - global log_disable_stdout + global log_disable_stdout # pylint: disable=global-statement log_disable_stdout = True def enable() -> None: - global log_disable_stdout + global log_disable_stdout # pylint: disable=global-statement log_disable_stdout = False def set_quiet() -> None: - global log_errors_only + global log_errors_only # pylint: disable=global-statement log_errors_only = True def set_verbose() -> None: - global log_errors_only + global log_errors_only # pylint: disable=global-statement log_errors_only = False def initialize(logdir: str, fatal_warnings: bool = False) -> None: - global log_dir, log_file, log_fatal_warnings + global log_dir, log_file, log_fatal_warnings # pylint: disable=global-statement log_dir = logdir log_file = open(os.path.join(logdir, log_fname), 'w', encoding='utf-8') log_fatal_warnings = fatal_warnings def set_timestamp_start(start: float) -> None: - global log_timestamp_start + global log_timestamp_start # pylint: disable=global-statement log_timestamp_start = start def shutdown() -> T.Optional[str]: - global log_file + global log_file # pylint: disable=global-statement if log_file is not None: path = log_file.name exception_around_goer = log_file @@ -333,7 +333,7 @@ def _log_error(severity: str, *rargs: TV_Loggable, log(*args, once=once, **kwargs) - global log_warnings_counter + global log_warnings_counter # pylint: disable=global-statement log_warnings_counter += 1 if log_fatal_warnings and fatal: |