diff options
author | Dylan Baker <dylan@pnwbakers.com> | 2020-09-24 09:53:41 -0700 |
---|---|---|
committer | Dylan Baker <dylan@pnwbakers.com> | 2021-06-02 15:53:17 -0700 |
commit | 113a1595149b72ee0a572ed215db616c5a6d8a20 (patch) | |
tree | 2ef6d92f919aaea3fb83b06631b38ebbe56aa9ce /mesonbuild/mesonlib/universal.py | |
parent | f8be4f8fc747772d9639fdbb6e84ddbcfb61593a (diff) | |
download | meson-113a1595149b72ee0a572ed215db616c5a6d8a20.zip meson-113a1595149b72ee0a572ed215db616c5a6d8a20.tar.gz meson-113a1595149b72ee0a572ed215db616c5a6d8a20.tar.bz2 |
use an immutable list for an lru_cached functions
When mutable items are stored in an lru cache, changing the returned
items changes the cached items as well. Therefore we want to ensure that
we're not mutating them. Using the ImmutableListProtocol allows mypy to
find mutations and reject them. This doesn't solve the problem of
mutable values inside the values, so you could have to do things like:
```python
ImmutableListProtocol[ImmutableListProtocol[str]]
```
or equally hacky. It can also be used for input types and acts a bit
like C's const:
```python
def foo(arg: ImmutableListProtocol[str]) -> T.List[str]:
arg[1] = 'foo' # works while running, but mypy errors
```
Diffstat (limited to 'mesonbuild/mesonlib/universal.py')
-rw-r--r-- | mesonbuild/mesonlib/universal.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mesonbuild/mesonlib/universal.py b/mesonbuild/mesonlib/universal.py index 66149f9..b8fc763 100644 --- a/mesonbuild/mesonlib/universal.py +++ b/mesonbuild/mesonlib/universal.py @@ -30,6 +30,7 @@ import textwrap from mesonbuild import mlog if T.TYPE_CHECKING: + from .._typing import ImmutableListProtocol from ..build import ConfigurationData from ..coredata import KeyedOptionDictType, UserOption from ..compilers.compilers import CompilerType @@ -659,7 +660,7 @@ def exe_exists(arglist: T.List[str]) -> bool: @lru_cache(maxsize=None) -def darwin_get_object_archs(objpath: str) -> T.List[str]: +def darwin_get_object_archs(objpath: str) -> 'ImmutableListProtocol[str]': ''' For a specific object (executable, static library, dylib, etc), run `lipo` to fetch the list of archs supported by it. Supports both thin objects and |