diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2022-09-07 14:59:47 -0700 |
|---|---|---|
| committer | Eli Schwartz <eschwartz@archlinux.org> | 2022-11-30 16:23:29 -0500 |
| commit | 2d349eae8cb6f1f3b61838dca7cc989e9278be28 (patch) | |
| tree | bc8d6325543e0df74b16941996f07797a746a2f6 /mesonbuild/environment.py | |
| parent | 50f35039e7df321a309ee45db57d37635bf53ce3 (diff) | |
| download | meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.zip meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.tar.gz meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.tar.bz2 | |
pylint: enable the set_membership plugin
Which adds the `use-set-for-membership` check. It's generally faster in
python to use a set with the `in` keyword, because it's a hash check
instead of a linear walk, this is especially true with strings, where
it's actually O(n^2), one loop over the container, and an inner loop of
the strings (as string comparison works by checking that `a[n] == b[n]`,
in a loop).
Also, I'm tired of complaining about this in reviews, let the tools do
it for me :)
Diffstat (limited to 'mesonbuild/environment.py')
| -rw-r--r-- | mesonbuild/environment.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mesonbuild/environment.py b/mesonbuild/environment.py index 40ce9d5..a9df75e 100644 --- a/mesonbuild/environment.py +++ b/mesonbuild/environment.py @@ -306,7 +306,7 @@ def detect_cpu_family(compilers: CompilersDict) -> str: trial = 'ppc64' elif trial.startswith(('powerpc', 'ppc')) or trial in {'macppc', 'power macintosh'}: trial = 'ppc' - elif trial in ('amd64', 'x64', 'i86pc'): + elif trial in {'amd64', 'x64', 'i86pc'}: trial = 'x86_64' elif trial in {'sun4u', 'sun4v'}: trial = 'sparc64' @@ -353,7 +353,7 @@ def detect_cpu(compilers: CompilersDict) -> str: else: trial = platform.machine().lower() - if trial in ('amd64', 'x64', 'i86pc'): + if trial in {'amd64', 'x64', 'i86pc'}: trial = 'x86_64' if trial == 'x86_64': # Same check as above for cpu_family |