diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2021-08-31 09:55:01 -0700 |
|---|---|---|
| committer | Eli Schwartz <eschwartz93@gmail.com> | 2021-08-31 16:28:54 -0400 |
| commit | 4d7031437c7a81b52c776d4ae1e32741bdb851ca (patch) | |
| tree | 7716c4af0d3f43b450a7c94dd42ae5dbef8ebdff /mesonbuild/compilers/mixins/clike.py | |
| parent | 06fdb29daace9ebe55e5df5336f65cba304773d2 (diff) | |
| download | meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.zip meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.tar.gz meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.tar.bz2 | |
pylint: turn on superflous-parens
We have a lot of these. Some of them are harmless, if unidiomatic, such
as `if (condition)`, others are potentially dangerous `assert(...)`, as
`assert(condtion)` works as expected, but `assert(condition, message)`
will result in an assertion that never triggers, as what you're actually
asserting is `bool(tuple[2])`, which will always be true.
Diffstat (limited to 'mesonbuild/compilers/mixins/clike.py')
| -rw-r--r-- | mesonbuild/compilers/mixins/clike.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/compilers/mixins/clike.py b/mesonbuild/compilers/mixins/clike.py index ccf14a4..d978f69 100644 --- a/mesonbuild/compilers/mixins/clike.py +++ b/mesonbuild/compilers/mixins/clike.py @@ -456,7 +456,7 @@ class CLikeCompiler(Compiler): # on MSVC compiler and linker flags must be separated by the "/link" argument # at this point, the '/link' argument may already be part of extra_args, otherwise, it is added here - if self.linker_to_compiler_args([]) == ['/link'] and largs != [] and not ('/link' in extra_args): + if self.linker_to_compiler_args([]) == ['/link'] and largs != [] and not '/link' in extra_args: extra_args += ['/link'] args = cargs + extra_args + largs |