aboutsummaryrefslogtreecommitdiff
path: root/mesonbuild/compilers/compilers.py
diff options
context:
space:
mode:
authorDylan Baker <dylan@pnwbakers.com>2020-09-24 09:53:41 -0700
committerDylan Baker <dylan@pnwbakers.com>2021-06-02 15:53:17 -0700
commit113a1595149b72ee0a572ed215db616c5a6d8a20 (patch)
tree2ef6d92f919aaea3fb83b06631b38ebbe56aa9ce /mesonbuild/compilers/compilers.py
parentf8be4f8fc747772d9639fdbb6e84ddbcfb61593a (diff)
downloadmeson-113a1595149b72ee0a572ed215db616c5a6d8a20.zip
meson-113a1595149b72ee0a572ed215db616c5a6d8a20.tar.gz
meson-113a1595149b72ee0a572ed215db616c5a6d8a20.tar.bz2
use an immutable list for an lru_cached functions
When mutable items are stored in an lru cache, changing the returned items changes the cached items as well. Therefore we want to ensure that we're not mutating them. Using the ImmutableListProtocol allows mypy to find mutations and reject them. This doesn't solve the problem of mutable values inside the values, so you could have to do things like: ```python ImmutableListProtocol[ImmutableListProtocol[str]] ``` or equally hacky. It can also be used for input types and acts a bit like C's const: ```python def foo(arg: ImmutableListProtocol[str]) -> T.List[str]: arg[1] = 'foo' # works while running, but mypy errors ```
Diffstat (limited to 'mesonbuild/compilers/compilers.py')
-rw-r--r--mesonbuild/compilers/compilers.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/mesonbuild/compilers/compilers.py b/mesonbuild/compilers/compilers.py
index 4eeaec7..361f5d6 100644
--- a/mesonbuild/compilers/compilers.py
+++ b/mesonbuild/compilers/compilers.py
@@ -1023,6 +1023,7 @@ class Compiler(metaclass=abc.ABCMeta):
raise EnvironmentException('This compiler does not have a preprocessor')
def get_default_include_dirs(self) -> T.List[str]:
+ # TODO: This is a candidate for returning an immutable list
return []
def get_largefile_args(self) -> T.List[str]: