diff options
| author | Jon Turney <jon.turney@dronecode.org.uk> | 2018-02-08 14:05:51 +0000 |
|---|---|---|
| committer | Jussi Pakkanen <jpakkane@gmail.com> | 2018-02-08 23:51:06 +0200 |
| commit | 0774f319e8fd255d251ea2ff79e8a070b013657e (patch) | |
| tree | 823e156a9d5acd548ac79520f5cc1d2023cbfc78 /mesonbuild/compilers/c.py | |
| parent | a9654c8533c05a4e25689d78238ee5114aa7f4f3 (diff) | |
| download | meson-0774f319e8fd255d251ea2ff79e8a070b013657e.zip meson-0774f319e8fd255d251ea2ff79e8a070b013657e.tar.gz meson-0774f319e8fd255d251ea2ff79e8a070b013657e.tar.bz2 | |
Don't use --export-dynamic on Cygwin
After PR #2662, running test case common/125 shared module/ on Cygwin gets
me:
$ ninja -C _build
ninja: Entering directory `_build'
[7/7] Linking target prog.exe.
/usr/lib/gcc/x86_64-pc-cygwin/6.4.0/../../../../x86_64-pc-cygwin/bin/ld: warning: --export-dynamic is not supported for PE+ targets, did you mean --export-all-symbols?
Also, fix doc for correct version of first apperance.
Future work: Notwithstanding the hint that ld gives, these options are not
equivalent, and it's not clear we should be using it here:
--export-all-symbols is the default behaviour, and if the exports are
restricted by explicit annotations or a .def file, this option might be
overriding that...
Diffstat (limited to 'mesonbuild/compilers/c.py')
| -rw-r--r-- | mesonbuild/compilers/c.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/compilers/c.py b/mesonbuild/compilers/c.py index f738615..a59b7d3 100644 --- a/mesonbuild/compilers/c.py +++ b/mesonbuild/compilers/c.py @@ -184,7 +184,7 @@ class CCompiler(Compiler): return [] def gen_export_dynamic_link_args(self, env): - if for_windows(env.is_cross_build(), env): + if for_windows(env.is_cross_build(), env) or for_cygwin(env.is_cross_build(), env): return ['-Wl,--export-all-symbols'] elif for_darwin(env.is_cross_build(), env): return [] |