diff options
author | Dylan Baker <dylan@pnwbakers.com> | 2021-01-22 12:48:22 -0800 |
---|---|---|
committer | Daniel Mensinger <daniel@mensinger-ka.de> | 2021-01-23 12:48:29 +0100 |
commit | 23d3b98fc1ed3b774cc3838da89b2e8f0f91800b (patch) | |
tree | 692320a9563026dede9650a56e78fc935cb93c5f /mesonbuild/compilers/c.py | |
parent | adb1b2f3f6ad54b346348ec6e5b8d96f2f7ba0a6 (diff) | |
download | meson-23d3b98fc1ed3b774cc3838da89b2e8f0f91800b.zip meson-23d3b98fc1ed3b774cc3838da89b2e8f0f91800b.tar.gz meson-23d3b98fc1ed3b774cc3838da89b2e8f0f91800b.tar.bz2 |
split mesonlib into a package
Currently mesonlib does some import tricks to figure out whether it
needs to use windows or posix specific functions. This is a little
hacky, but works fine. However, the way the typing stubs are implemented
for the msvcrt and fnctl modules will cause mypy to fail on the other
platform, since the functions are not implemented.
To aleviate this (and for slightly cleaner design), I've split mesonlib
into a pacakge with three modules. A universal module contains all of
the platform agnositc code, a win32 module contains window specific
code, a posix module contains the posix specific code, and a platform
module contains no-op implementations. Then the package's __init__ file
imports all of the universal functions and all of the functions from the
approriate platform module, or the no-op versions as fallbacks. This
makes mypy happy, and avoids `if`ing all over the code to switch between
the platform specific code.
Diffstat (limited to 'mesonbuild/compilers/c.py')
-rw-r--r-- | mesonbuild/compilers/c.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mesonbuild/compilers/c.py b/mesonbuild/compilers/c.py index c11319b..0a2d478 100644 --- a/mesonbuild/compilers/c.py +++ b/mesonbuild/compilers/c.py @@ -16,7 +16,8 @@ import os.path import typing as T from .. import coredata -from ..mesonlib import MachineChoice, MesonException, mlog, version_compare, OptionKey +from .. import mlog +from ..mesonlib import MachineChoice, MesonException, version_compare, OptionKey from .c_function_attributes import C_FUNC_ATTRIBUTES from .mixins.clike import CLikeCompiler from .mixins.ccrx import CcrxCompiler |