diff options
| author | Dylan Baker <dylan@pnwbakers.com> | 2022-09-07 14:59:47 -0700 |
|---|---|---|
| committer | Eli Schwartz <eschwartz@archlinux.org> | 2022-11-30 16:23:29 -0500 |
| commit | 2d349eae8cb6f1f3b61838dca7cc989e9278be28 (patch) | |
| tree | bc8d6325543e0df74b16941996f07797a746a2f6 /mesonbuild/cmake/interpreter.py | |
| parent | 50f35039e7df321a309ee45db57d37635bf53ce3 (diff) | |
| download | meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.zip meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.tar.gz meson-2d349eae8cb6f1f3b61838dca7cc989e9278be28.tar.bz2 | |
pylint: enable the set_membership plugin
Which adds the `use-set-for-membership` check. It's generally faster in
python to use a set with the `in` keyword, because it's a hash check
instead of a linear walk, this is especially true with strings, where
it's actually O(n^2), one loop over the container, and an inner loop of
the strings (as string comparison works by checking that `a[n] == b[n]`,
in a loop).
Also, I'm tired of complaining about this in reviews, let the tools do
it for me :)
Diffstat (limited to 'mesonbuild/cmake/interpreter.py')
| -rw-r--r-- | mesonbuild/cmake/interpreter.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/mesonbuild/cmake/interpreter.py b/mesonbuild/cmake/interpreter.py index f96333a..f453aa3 100644 --- a/mesonbuild/cmake/interpreter.py +++ b/mesonbuild/cmake/interpreter.py @@ -320,7 +320,7 @@ class ConverterTarget: ) continue self.override_options += [f'{i}_std={std}'] - elif j in ['-fPIC', '-fpic', '-fPIE', '-fpie']: + elif j in {'-fPIC', '-fpic', '-fPIE', '-fpie'}: self.pie = True elif isinstance(ctgt, ConverterCustomTarget): # Sometimes projects pass generated source files as compiler @@ -1173,10 +1173,10 @@ class CMakeInterpreter: src_node = assign(src_var, function('files', sources)) tgt_node = assign(tgt_var, function(tgt_func, [tgt_var, id_node(src_var), *generated], tgt_kwargs)) node_list += [src_node, tgt_node] - if tgt_func in ['static_library', 'shared_library']: + if tgt_func in {'static_library', 'shared_library'}: dep_node = assign(dep_var, function('declare_dependency', kwargs=dep_kwargs)) node_list += [dep_node] - elif tgt_func in ['shared_module']: + elif tgt_func == 'shared_module': del dep_kwargs['link_with'] dep_node = assign(dep_var, function('declare_dependency', kwargs=dep_kwargs)) node_list += [dep_node] |