diff options
author | Dylan Baker <dylan@pnwbakers.com> | 2023-01-09 11:12:15 -0800 |
---|---|---|
committer | Dylan Baker <dylan@pnwbakers.com> | 2023-01-10 13:02:07 -0800 |
commit | 6aeec808367f05463394e30a8d40834e97c7afc0 (patch) | |
tree | 3c257977bfc010242b2393e7febd1ce70df818c0 /mesonbuild/backend/xcodebackend.py | |
parent | 8655287c562cd54823add07b6d7a2c76c205d7fc (diff) | |
download | meson-6aeec808367f05463394e30a8d40834e97c7afc0.zip meson-6aeec808367f05463394e30a8d40834e97c7afc0.tar.gz meson-6aeec808367f05463394e30a8d40834e97c7afc0.tar.bz2 |
backends: Stop passing generator exes to ExecutableSerialisation as strings
The code below this already handles being passed an Executable or
ExternalProgram, and it does it correctly, since it handles host
binaries that need an exe_wrapper correctly, while the code in the
generator paths doesn't.
The xcode backend is, like always, problematic, it doesn't handle things
the same way as the ninja and vscode backends, and generates a shell
script instead of using meson as a wrapper when needed (it seems likely
that just forcing the meson path for xcode would be better). I don't
have a working mac to develop a fix for, so I've left a todo comment
there.
Fixes: #11264
Diffstat (limited to 'mesonbuild/backend/xcodebackend.py')
-rw-r--r-- | mesonbuild/backend/xcodebackend.py | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/mesonbuild/backend/xcodebackend.py b/mesonbuild/backend/xcodebackend.py index c56036b..605ee22 100644 --- a/mesonbuild/backend/xcodebackend.py +++ b/mesonbuild/backend/xcodebackend.py @@ -1219,6 +1219,8 @@ class XCodeBackend(backends.Backend): generator_id += 1 def generate_single_generator_phase(self, tname, t, genlist, generator_id, objects_dict): + # TODO: this should be rewritten to use the meson wrapper, like the other generators do + # Currently it doesn't handle a host binary that requires an exe wrapper correctly. generator = genlist.get_generator() exe = generator.get_exe() exe_arr = self.build_target_to_cmd_array(exe) |