aboutsummaryrefslogtreecommitdiff
path: root/mesonbuild/backend/xcodebackend.py
diff options
context:
space:
mode:
authorDylan Baker <dylan@pnwbakers.com>2021-08-31 10:08:01 -0700
committerEli Schwartz <eschwartz93@gmail.com>2021-08-31 16:28:54 -0400
commitb60bd0e299460c436acba43de27ac52afb11026b (patch)
treed1e66beb2c83625bfc86acbac7ce419980fd5013 /mesonbuild/backend/xcodebackend.py
parent4d7031437c7a81b52c776d4ae1e32741bdb851ca (diff)
downloadmeson-b60bd0e299460c436acba43de27ac52afb11026b.zip
meson-b60bd0e299460c436acba43de27ac52afb11026b.tar.gz
meson-b60bd0e299460c436acba43de27ac52afb11026b.tar.bz2
pyllint: enable consider-user-enumerate
This caught a couple of cases of us doing: ```python for i in range(len(x)): v = x[i] ``` which are places to use enumerate instead. It also caught a couple of cases of: ```python assert len(x) == len(y) for i in range(len(x)): xv = x[i] yv = y[i] ``` Which should instead be using zip() ```python for xv, yv in zip(x, y): ... ```
Diffstat (limited to 'mesonbuild/backend/xcodebackend.py')
-rw-r--r--mesonbuild/backend/xcodebackend.py8
1 files changed, 2 insertions, 6 deletions
diff --git a/mesonbuild/backend/xcodebackend.py b/mesonbuild/backend/xcodebackend.py
index 1139f79..5b3d33e 100644
--- a/mesonbuild/backend/xcodebackend.py
+++ b/mesonbuild/backend/xcodebackend.py
@@ -678,9 +678,7 @@ class XCodeBackend(backends.Backend):
file_ids = self.generator_buildfile_ids[(tname, generator_id)]
ref_ids = self.generator_fileref_ids[(tname, generator_id)]
assert len(ref_ids) == len(file_ids)
- for i in range(len(file_ids)):
- file_o = file_ids[i]
- ref_id = ref_ids[i]
+ for file_o, ref_id in zip(file_ids, ref_ids):
odict = PbxDict()
objects_dict.add_item(file_o, odict)
odict.add_item('isa', 'PBXBuildFile')
@@ -758,9 +756,7 @@ class XCodeBackend(backends.Backend):
outputs = self.generator_outputs[(tname, generator_id)]
ref_ids = self.generator_fileref_ids[tname, generator_id]
assert len(ref_ids) == len(outputs)
- for i in range(len(outputs)):
- o = outputs[i]
- ref_id = ref_ids[i]
+ for o, ref_id in zip(outputs, ref_ids):
odict = PbxDict()
name = os.path.basename(o)
objects_dict.add_item(ref_id, odict, o)