diff options
author | Dylan Baker <dylan@pnwbakers.com> | 2021-08-31 09:55:01 -0700 |
---|---|---|
committer | Eli Schwartz <eschwartz93@gmail.com> | 2021-08-31 16:28:54 -0400 |
commit | 4d7031437c7a81b52c776d4ae1e32741bdb851ca (patch) | |
tree | 7716c4af0d3f43b450a7c94dd42ae5dbef8ebdff /ghwt.py | |
parent | 06fdb29daace9ebe55e5df5336f65cba304773d2 (diff) | |
download | meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.zip meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.tar.gz meson-4d7031437c7a81b52c776d4ae1e32741bdb851ca.tar.bz2 |
pylint: turn on superflous-parens
We have a lot of these. Some of them are harmless, if unidiomatic, such
as `if (condition)`, others are potentially dangerous `assert(...)`, as
`assert(condtion)` works as expected, but `assert(condition, message)`
will result in an assertion that never triggers, as what you're actually
asserting is `bool(tuple[2])`, which will always be true.
Diffstat (limited to 'ghwt.py')
-rwxr-xr-x | ghwt.py | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -45,7 +45,7 @@ def unpack(sproj, branch): shutil.rmtree(tmpdir, ignore_errors=True) subprocess.check_call(['git', 'clone', '-b', branch, f'https://github.com/mesonbuild/{sproj}.git', tmpdir]) usfile = os.path.join(tmpdir, 'upstream.wrap') - assert(os.path.isfile(usfile)) + assert os.path.isfile(usfile) config = configparser.ConfigParser(interpolation=None) config.read(usfile) outdir = os.path.join(spdir, sproj) @@ -74,7 +74,7 @@ def unpack(sproj, branch): shutil.unpack_archive(ofilename, outdir) else: shutil.unpack_archive(ofilename, spdir) - assert(os.path.isdir(outdir)) + assert os.path.isdir(outdir) shutil.move(os.path.join(tmpdir, '.git'), outdir) subprocess.check_call(['git', 'reset', '--hard'], cwd=outdir) shutil.rmtree(tmpdir) |