aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorXavier Claessens <xavier.claessens@collabora.com>2023-08-08 15:10:38 -0400
committerXavier Claessens <xavier.claessens@collabora.com>2023-08-08 15:10:38 -0400
commit39ea753d1ff3e3e600d67a198fd0a41874bf90f7 (patch)
treedd783240214de6a75946233de63cecff4987945d
parent926c3a69195385bd5c16acd269f4dae5322e0c03 (diff)
downloadmeson-wip/xclaesse/pr-12097.zip
meson-wip/xclaesse/pr-12097.tar.gz
meson-wip/xclaesse/pr-12097.tar.bz2
backend: Stop converting all "\" to "/" in commandwip/xclaesse/pr-12097
We tried removing that hack in https://github.com/mesonbuild/meson/pull/737 but it had to be reverted with no real explanation 8 years ago: https://github.com/mesonbuild/meson/issues/773 Things changed since, we could be in a better world, let's try again.
-rw-r--r--mesonbuild/backend/backends.py19
1 files changed, 0 insertions, 19 deletions
diff --git a/mesonbuild/backend/backends.py b/mesonbuild/backend/backends.py
index 62cf162..ff48177 100644
--- a/mesonbuild/backend/backends.py
+++ b/mesonbuild/backend/backends.py
@@ -1572,25 +1572,6 @@ class Backend:
# Substitute the rest of the template strings
values = mesonlib.get_filenames_templates_dict(inputs, outputs)
cmd = mesonlib.substitute_values(cmd, values)
- # This should not be necessary but removing it breaks
- # building GStreamer on Windows. The underlying issue
- # is problems with quoting backslashes on Windows
- # which is the seventh circle of hell. The downside is
- # that this breaks custom targets whose command lines
- # have backslashes. If you try to fix this be sure to
- # check that it does not break GST.
- #
- # The bug causes file paths such as c:\foo to get escaped
- # into c:\\foo.
- #
- # Unfortunately we have not been able to come up with an
- # isolated test case for this so unless you manage to come up
- # with one, the only way is to test the building with Gst's
- # setup. Note this in your MR or ping us and we will get it
- # fixed.
- #
- # https://github.com/mesonbuild/meson/pull/737
- cmd = [i.replace('\\', '/') for i in cmd]
return inputs, outputs, cmd
def get_run_target_env(self, target: build.RunTarget) -> mesonlib.EnvironmentVariables: