aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDylan Baker <dylan@pnwbakers.com>2021-04-27 11:37:44 -0700
committerJussi Pakkanen <jpakkane@gmail.com>2021-05-19 23:28:17 +0300
commitbfd06783bd999a59fb0a375d35c25a4ae7b3e17e (patch)
treedd3ad8aa816ca11dd6a4494fca46a5f43a4e277b
parent156d6160d1075d3e304ea544e9d68349e00ad80d (diff)
downloadmeson-bfd06783bd999a59fb0a375d35c25a4ae7b3e17e.zip
meson-bfd06783bd999a59fb0a375d35c25a4ae7b3e17e.tar.gz
meson-bfd06783bd999a59fb0a375d35c25a4ae7b3e17e.tar.bz2
backends: use a set for processed targets instead of a dict
We're only interested in the keys, not in the value (which was always set to True), so a set is a better data structure anyway.
-rw-r--r--mesonbuild/backend/backends.py2
-rw-r--r--mesonbuild/backend/ninjabackend.py6
2 files changed, 4 insertions, 4 deletions
diff --git a/mesonbuild/backend/backends.py b/mesonbuild/backend/backends.py
index ee5f446..4d20ac5 100644
--- a/mesonbuild/backend/backends.py
+++ b/mesonbuild/backend/backends.py
@@ -224,7 +224,7 @@ class Backend:
self.build = build
self.interpreter = interpreter
self.environment = build.environment
- self.processed_targets = {}
+ self.processed_targets: T.Set[str] = set()
self.name = '<UNKNOWN>'
self.build_dir = self.environment.get_build_dir()
self.source_dir = self.environment.get_source_dir()
diff --git a/mesonbuild/backend/ninjabackend.py b/mesonbuild/backend/ninjabackend.py
index bf3a6d7..2d826b4 100644
--- a/mesonbuild/backend/ninjabackend.py
+++ b/mesonbuild/backend/ninjabackend.py
@@ -702,7 +702,7 @@ int dummy;
name = target.get_id()
if name in self.processed_targets:
return
- self.processed_targets[name] = True
+ self.processed_targets.add(name)
# Initialize an empty introspection source list
self.introspection_data[name] = {}
# Generate rules for all dependency targets
@@ -979,7 +979,7 @@ int dummy;
elem.add_item('COMMAND', cmd)
elem.add_item('description', desc.format(target.name, cmd_type))
self.add_build(elem)
- self.processed_targets[target.get_id()] = True
+ self.processed_targets.add(target.get_id())
def build_run_target_name(self, target):
if target.subproject != '':
@@ -1013,7 +1013,7 @@ int dummy;
deps += self.get_custom_target_depend_files(target)
elem.add_dep(deps)
self.add_build(elem)
- self.processed_targets[target.get_id()] = True
+ self.processed_targets.add(target.get_id())
def generate_coverage_command(self, elem, outputs):
targets = self.build.get_targets().values()