diff options
| author | Luke Elliott <luke.b.elliott@gmail.com> | 2021-01-10 15:54:20 +0000 |
|---|---|---|
| committer | Eli Schwartz <eschwartz93@gmail.com> | 2022-10-13 09:02:54 -0400 |
| commit | 4f0452b2835c19dfd7b6ada2f6eb54c48ef8e564 (patch) | |
| tree | 0706e12941d8b595d9ea968be082b507207706fb | |
| parent | 673dca5c0716d4e9527c055a8a20fa11e1893c5b (diff) | |
| download | meson-4f0452b2835c19dfd7b6ada2f6eb54c48ef8e564.zip meson-4f0452b2835c19dfd7b6ada2f6eb54c48ef8e564.tar.gz meson-4f0452b2835c19dfd7b6ada2f6eb54c48ef8e564.tar.bz2 | |
fix: don't set FavorSizeOrSpeed in vs backend if optimization disabled (/Od set).
Debugging is broken with clang-cl when FavorSizeOrSpeed is set.
| -rw-r--r-- | mesonbuild/backend/vs2010backend.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mesonbuild/backend/vs2010backend.py b/mesonbuild/backend/vs2010backend.py index e747dfa..98d69e7 100644 --- a/mesonbuild/backend/vs2010backend.py +++ b/mesonbuild/backend/vs2010backend.py @@ -1159,7 +1159,8 @@ class Vs2010Backend(backends.Backend): # Size-preserving flags if '/Os' in o_flags: ET.SubElement(clconf, 'FavorSizeOrSpeed').text = 'Size' - else: + # Note: setting FavorSizeOrSpeed with clang-cl conflicts with /Od and can make debugging difficult, so don't. + elif '/Od' not in o_flags: ET.SubElement(clconf, 'FavorSizeOrSpeed').text = 'Speed' # Note: SuppressStartupBanner is /NOLOGO and is 'true' by default self.generate_lang_standard_info(file_args, clconf) |