aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDylan Baker <dylan@pnwbakers.com>2021-07-28 12:05:09 -0700
committerXavier Claessens <xclaesse@gmail.com>2021-08-09 19:44:49 -0400
commit6a83f8b9cbac9eaa31307064b589d3ef41c0a293 (patch)
treeb411d699396615c36a54331ceee7c874dec3ff16
parent8a7451e051240b3b36b057fb2cbb3c60c9fdf493 (diff)
downloadmeson-6a83f8b9cbac9eaa31307064b589d3ef41c0a293.zip
meson-6a83f8b9cbac9eaa31307064b589d3ef41c0a293.tar.gz
meson-6a83f8b9cbac9eaa31307064b589d3ef41c0a293.tar.bz2
build: store global and project args per-machine even when not cross compiling
The problem is what happens in this case: ```meson add_project_arguments('-DHOST', language : 'c', native : false) add_project_arguments('-DBUILD', langauge : 'c', native : true) ``` The original meson behavior was that in an host == build configuration only the `native : false` would be applied. This doesn't really make sense as in that case the build machine is the host machine, so it is both the native and non-native machine at once. We changed this so that the both would be applied in a host == build configuration, but this is a behavioral change, and needs to be reverted. Fixes: #9037
-rw-r--r--mesonbuild/build.py12
1 files changed, 4 insertions, 8 deletions
diff --git a/mesonbuild/build.py b/mesonbuild/build.py
index a48b057..28ad60e 100644
--- a/mesonbuild/build.py
+++ b/mesonbuild/build.py
@@ -212,14 +212,10 @@ class Build:
self.projects = {}
self.targets: T.MutableMapping[str, 'Target'] = OrderedDict()
self.run_target_names: T.Set[T.Tuple[str, str]] = set()
- self.global_args: PerMachine[T.Dict[str, T.List[str]]] = PerMachineDefaultable.default(
- environment.is_cross_build(), {}, {})
- self.global_link_args: PerMachine[T.Dict[str, T.List[str]]] = PerMachineDefaultable.default(
- environment.is_cross_build(), {}, {})
- self.projects_args: PerMachine[T.Dict[str, T.Dict[str, T.List[str]]]] = PerMachineDefaultable.default(
- environment.is_cross_build(), {}, {})
- self.projects_link_args: PerMachine[T.Dict[str, T.Dict[str, T.List[str]]]] = PerMachineDefaultable.default(
- environment.is_cross_build(), {}, {})
+ self.global_args: PerMachine[T.Dict[str, T.List[str]]] = PerMachine({}, {})
+ self.global_link_args: PerMachine[T.Dict[str, T.List[str]]] = PerMachine({}, {})
+ self.projects_args: PerMachine[T.Dict[str, T.Dict[str, T.List[str]]]] = PerMachine({}, {})
+ self.projects_link_args: PerMachine[T.Dict[str, T.Dict[str, T.List[str]]]] = PerMachine({}, {})
self.tests: T.List['Test'] = []
self.benchmarks: T.List['Test'] = []
self.headers: T.List[Headers] = []