diff options
author | Eli Schwartz <eschwartz@archlinux.org> | 2022-02-09 21:13:26 -0500 |
---|---|---|
committer | Eli Schwartz <eschwartz@archlinux.org> | 2022-04-12 20:44:07 -0400 |
commit | b5a81ff6348ccd8351af495e21884cbb7a56f308 (patch) | |
tree | f07295c0ad012e3f5b0cdc0d26fb8c544209c929 | |
parent | e223136b10a55ebb24c780575092bbf67dd1581c (diff) | |
download | meson-b5a81ff6348ccd8351af495e21884cbb7a56f308.zip meson-b5a81ff6348ccd8351af495e21884cbb7a56f308.tar.gz meson-b5a81ff6348ccd8351af495e21884cbb7a56f308.tar.bz2 |
qt dependency: adapt to the qmake command changed name
Qt now has official guidance for the symlinked names of the tools, which
is great.
Qt now officially calls the tools `fooX` instead of `foo-qtX` where the
major version of Qt is X. Which is not great, because a bit of an
unofficial standard had prior art and now needs to change, and we never
adapted.
Prefer the official name whenever looking up qmake, and in the
testsuite, specifically look only for the official name on versions of
qt which we know should have that.
-rw-r--r-- | mesonbuild/dependencies/qt.py | 2 | ||||
-rw-r--r-- | unittests/linuxliketests.py | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/mesonbuild/dependencies/qt.py b/mesonbuild/dependencies/qt.py index bad8ceb..562792c 100644 --- a/mesonbuild/dependencies/qt.py +++ b/mesonbuild/dependencies/qt.py @@ -245,7 +245,7 @@ class QmakeQtDependency(_QtBase, ConfigToolDependency, metaclass=abc.ABCMeta): def __init__(self, name: str, env: 'Environment', kwargs: T.Dict[str, T.Any]): _QtBase.__init__(self, name, kwargs) - self.tools = [f'qmake-{self.name}', 'qmake'] + self.tools = [f'qmake{self.qtver}', f'qmake-{self.name}', 'qmake'] # Add additional constraints that the Qt version is met, but preserve # any version requrements the user has set as well. For example, if Qt5 diff --git a/unittests/linuxliketests.py b/unittests/linuxliketests.py index 406950e..565b328 100644 --- a/unittests/linuxliketests.py +++ b/unittests/linuxliketests.py @@ -387,8 +387,8 @@ class LinuxlikeTests(BasePlatformTests): Test that qt6 detection with qmake works. This can't be an ordinary test case because it involves setting the environment. ''' - # Verify that qmake is for Qt5 - if not shutil.which('qmake-qt6'): + # Verify that qmake is for Qt6 + if not shutil.which('qmake6'): if not shutil.which('qmake'): raise SkipTest('QMake not found') output = subprocess.getoutput('qmake --version') |