aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Thursfield <sam@afuera.me.uk>2017-04-02 13:29:46 +0100
committerSam Thursfield <sam@afuera.me.uk>2017-04-03 17:02:45 +0100
commitc408bd6a8eb31b261170de09e20ecf8e0317152e (patch)
tree9eed89c9b2762b5cd380fb5fb5071bc570688cc8
parente0c5e4082689e6e49d80c574f35b9e401b7fc83a (diff)
downloadmeson-c408bd6a8eb31b261170de09e20ecf8e0317152e.zip
meson-c408bd6a8eb31b261170de09e20ecf8e0317152e.tar.gz
meson-c408bd6a8eb31b261170de09e20ecf8e0317152e.tar.bz2
gnome: Preserve ordering of flags passed to tools
This avoids unnecessary rebuilds occuring when Meson regenerates the build.ninja file. Previously, if the ordering of the commandline arguments changed then Ninja would consider the outputs dirty and rebuild them.
-rw-r--r--mesonbuild/modules/gnome.py10
1 files changed, 5 insertions, 5 deletions
diff --git a/mesonbuild/modules/gnome.py b/mesonbuild/modules/gnome.py
index 4b366bf..481a250 100644
--- a/mesonbuild/modules/gnome.py
+++ b/mesonbuild/modules/gnome.py
@@ -21,7 +21,7 @@ import sys
import copy
import subprocess
from . import ModuleReturnValue
-from ..mesonlib import MesonException, Popen_safe
+from ..mesonlib import MesonException, OrderedSet, Popen_safe
from ..dependencies import Dependency, PkgConfigDependency, InternalDependency
from .. import mlog
from .. import mesonlib
@@ -154,7 +154,7 @@ class GnomeModule(ExtensionModule):
# Ensure build directories of generated deps are included
source_dirs += subdirs
- for source_dir in set(source_dirs):
+ for source_dir in OrderedSet(source_dirs):
cmd += ['--sourcedir', source_dir]
if 'c_name' in kwargs:
@@ -299,9 +299,9 @@ class GnomeModule(ExtensionModule):
def _get_dependencies_flags(self, deps, state, depends=None, include_rpath=False,
use_gir_args=False):
- cflags = set()
- ldflags = set()
- gi_includes = set()
+ cflags = OrderedSet()
+ ldflags = OrderedSet()
+ gi_includes = OrderedSet()
if not isinstance(deps, list):
deps = [deps]