diff options
author | Nirbheek Chauhan <nirbheek@centricular.com> | 2016-12-19 20:10:11 +0530 |
---|---|---|
committer | Jussi Pakkanen <jpakkane@gmail.com> | 2016-12-19 21:37:27 +0200 |
commit | b4cead2763460d11ed3a6f467618f65716021bd2 (patch) | |
tree | 9e8e30b78faf5dd275a01652ad60f6913fba4929 | |
parent | 7d71e9f8b2b303c20c1e7e00f14feca0ec5e08f2 (diff) | |
download | meson-b4cead2763460d11ed3a6f467618f65716021bd2.zip meson-b4cead2763460d11ed3a6f467618f65716021bd2.tar.gz meson-b4cead2763460d11ed3a6f467618f65716021bd2.tar.bz2 |
find_program: Don't leak mutable array in get_command()
In several places in the gnome module, we are getting an array from this
and directly appending to it which changes the original command array
ever since we started caching the find_program results.
We urgently need to move to immutable types for all object properties.
Reported by Alexandor Larsson on IRC.
-rw-r--r-- | mesonbuild/dependencies.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mesonbuild/dependencies.py b/mesonbuild/dependencies.py index aa3927f..7b6d4c8 100644 --- a/mesonbuild/dependencies.py +++ b/mesonbuild/dependencies.py @@ -476,7 +476,7 @@ class ExternalProgram(): return self.fullpath[0] is not None def get_command(self): - return self.fullpath + return self.fullpath[:] def get_name(self): return self.name |