aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNicolas Schneider <nioncode+git@gmail.com>2016-02-23 22:55:13 +0100
committerNicolas Schneider <nioncode+git@gmail.com>2016-02-23 22:55:13 +0100
commit2dcac3862413ef6ebb536aabd91366ac7bd0cca4 (patch)
tree4651200c5f85b84195eb7ab4e4e3d07133e636a1
parented6c0e1fa6a1d1709ace6b3e8c26d1a2d1546cb2 (diff)
downloadmeson-2dcac3862413ef6ebb536aabd91366ac7bd0cca4.zip
meson-2dcac3862413ef6ebb536aabd91366ac7bd0cca4.tar.gz
meson-2dcac3862413ef6ebb536aabd91366ac7bd0cca4.tar.bz2
vs2010: write CustomBuildStep only if there is at least 1 command to be run
-rw-r--r--mesonbuild/backend/vs2010backend.py17
1 files changed, 9 insertions, 8 deletions
diff --git a/mesonbuild/backend/vs2010backend.py b/mesonbuild/backend/vs2010backend.py
index 6d97cdd..378b1a8 100644
--- a/mesonbuild/backend/vs2010backend.py
+++ b/mesonbuild/backend/vs2010backend.py
@@ -37,7 +37,6 @@ class Vs2010Backend(backends.Backend):
self.source_suffix_in_obj = False
def generate_custom_generator_commands(self, target, parent_node):
- idgroup = ET.SubElement(parent_node, 'ItemDefinitionGroup')
all_output_files = []
commands = []
inputs = []
@@ -73,13 +72,15 @@ class Vs2010Backend(backends.Backend):
commands.append(' '.join(self.special_quote(fullcmd)))
inputs.append(infilename)
outputs.extend(outfiles)
- cbs = ET.SubElement(idgroup, 'CustomBuildStep')
- ET.SubElement(cbs, 'Command').text = '\r\n'.join(commands)
- ET.SubElement(cbs, 'Inputs').text = ";".join(inputs)
- ET.SubElement(cbs, 'Outputs').text = ';'.join(outputs)
- ET.SubElement(cbs, 'Message').text = 'Generating custom sources.'
- pg = ET.SubElement(parent_node, 'PropertyGroup')
- ET.SubElement(pg, 'CustomBuildBeforeTargets').text = 'ClCompile'
+ if len(commands) > 0:
+ idgroup = ET.SubElement(parent_node, 'ItemDefinitionGroup')
+ cbs = ET.SubElement(idgroup, 'CustomBuildStep')
+ ET.SubElement(cbs, 'Command').text = '\r\n'.join(commands)
+ ET.SubElement(cbs, 'Inputs').text = ";".join(inputs)
+ ET.SubElement(cbs, 'Outputs').text = ';'.join(outputs)
+ ET.SubElement(cbs, 'Message').text = 'Generating custom sources.'
+ pg = ET.SubElement(parent_node, 'PropertyGroup')
+ ET.SubElement(pg, 'CustomBuildBeforeTargets').text = 'ClCompile'
return all_output_files
def generate(self, interp):