diff options
| author | Leif Middelschulte <leif.middelschulte@gmail.com> | 2017-09-30 19:45:24 +0200 |
|---|---|---|
| committer | Leif Middelschulte <leif.middelschulte@gmail.com> | 2017-09-30 19:45:24 +0200 |
| commit | 078527a744b7903758758469077f10d6b9bf37b3 (patch) | |
| tree | 069ad99028dea3e9140f22835a7e6c5958d568cb | |
| parent | 50376cca37324594c4f7ff9007b50ae837b46be2 (diff) | |
| download | meson-078527a744b7903758758469077f10d6b9bf37b3.zip meson-078527a744b7903758758469077f10d6b9bf37b3.tar.gz meson-078527a744b7903758758469077f10d6b9bf37b3.tar.bz2 | |
As per jpakkane's suggestion use `Popen_safe` instead of `subprocess.getoutput`
Jussi suggested to use `Popen_safe` from meson's library for portability reasons.
| -rw-r--r-- | mesonbuild/wrap/wrap.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/mesonbuild/wrap/wrap.py b/mesonbuild/wrap/wrap.py index 436dc56..387a05c 100644 --- a/mesonbuild/wrap/wrap.py +++ b/mesonbuild/wrap/wrap.py @@ -237,7 +237,8 @@ class Resolver: revno = p.get('revision') is_there = os.path.isdir(checkoutdir) if is_there: - current_revno = subprocess.getoutput(' '.join(['svn', 'info', '--show-item', 'revision', checkoutdir])) + p, out = Popen_safe(['svn', 'info', '--show-item', 'revision', checkoutdir]) + current_revno = out if current_revno == revno: return |