diff options
author | Xavier Claessens <xavier.claessens@collabora.com> | 2022-10-30 09:59:07 -0400 |
---|---|---|
committer | Eli Schwartz <eschwartz93@gmail.com> | 2022-10-31 20:21:07 -0400 |
commit | 81763e610fac24c7a9720fa37630e7660111c4a6 (patch) | |
tree | 4f880836699a096afd30e6d0715deaa3c2429aa4 | |
parent | 8d8ce4fb774aacb26d4710627a245781df2a3446 (diff) | |
download | meson-81763e610fac24c7a9720fa37630e7660111c4a6.zip meson-81763e610fac24c7a9720fa37630e7660111c4a6.tar.gz meson-81763e610fac24c7a9720fa37630e7660111c4a6.tar.bz2 |
both_libraries: Make sure to select the right linker for static lib
Regression test: libccpp has both C and C++ sources. The executable only
has C sources. It should still link using the C++ compiler. When using
both_libraries the static has no sources and thus no compilers,
resulting in the executable linking using the C compiler.
https://github.com/Netflix/vmaf/issues/1107
-rw-r--r-- | mesonbuild/interpreter/interpreter.py | 5 | ||||
-rw-r--r-- | test cases/common/178 bothlibraries/foo.cpp | 11 | ||||
-rw-r--r-- | test cases/common/178 bothlibraries/main2.c | 9 | ||||
-rw-r--r-- | test cases/common/178 bothlibraries/meson.build | 14 |
4 files changed, 35 insertions, 4 deletions
diff --git a/mesonbuild/interpreter/interpreter.py b/mesonbuild/interpreter/interpreter.py index 056cc32..0bab57e 100644 --- a/mesonbuild/interpreter/interpreter.py +++ b/mesonbuild/interpreter/interpreter.py @@ -101,7 +101,6 @@ import typing as T import textwrap import importlib import copy -import itertools if T.TYPE_CHECKING: import argparse @@ -3093,8 +3092,8 @@ Try setting b_lundef to false instead.'''.format(self.coredata.options[OptionKey static_lib.sources = [] static_lib.generated = [] # Compilers with no corresponding sources confuses the backend. - # Keep only the first compiler because it is the linker. - static_lib.compilers = dict(itertools.islice(static_lib.compilers.items(), 1)) + # Keep only compilers used for linking + static_lib.compilers = {k: v for k, v in static_lib.compilers.items() if k in compilers.clink_langs} return build.BothLibraries(shared_lib, static_lib) diff --git a/test cases/common/178 bothlibraries/foo.cpp b/test cases/common/178 bothlibraries/foo.cpp new file mode 100644 index 0000000..a705cbc --- /dev/null +++ b/test cases/common/178 bothlibraries/foo.cpp @@ -0,0 +1,11 @@ +#include <memory> +#include "mylib.h" + +extern "C" { + DO_EXPORT int foo(void); +} + +int foo(void) { + auto bptr = std::make_shared<int>(0); + return *bptr; +} diff --git a/test cases/common/178 bothlibraries/main2.c b/test cases/common/178 bothlibraries/main2.c new file mode 100644 index 0000000..e1f4bf8 --- /dev/null +++ b/test cases/common/178 bothlibraries/main2.c @@ -0,0 +1,9 @@ +#include "mylib.h" + +DO_IMPORT int func(void); +DO_IMPORT int foo(void); +DO_IMPORT int retval; + +int main(void) { + return func() + foo() == retval ? 0 : 1; +} diff --git a/test cases/common/178 bothlibraries/meson.build b/test cases/common/178 bothlibraries/meson.build index f3191cc..bb3a2bc 100644 --- a/test cases/common/178 bothlibraries/meson.build +++ b/test cases/common/178 bothlibraries/meson.build @@ -1,4 +1,4 @@ -project('both libraries linking test', 'c') +project('both libraries linking test', 'c', 'cpp') both_libs = both_libraries('mylib', 'libfile.c') dep = declare_dependency(link_with: both_libs) @@ -48,3 +48,15 @@ assert(both_libs3.get_static_lib().name() == 'mylib') test('runtest-shared-2', exe_shared2) test('runtest-static-2', exe_static2) test('runtest-both-2', exe_both2) + +# Regression test: libccpp has both C and C++ sources. The executable only has +# C sources. It should still link using the C++ compiler. When using +# both_libraries the static has no sources and thus no compilers, resulting in +# the executable linking using the C compiler. +# https://github.com/Netflix/vmaf/issues/1107 +libccpp = both_libraries('ccpp', 'foo.cpp', 'libfile.c') +exe = executable('prog-ccpp', 'main2.c', + link_with: libccpp.get_static_lib(), + c_args : ['-DSTATIC_COMPILATION'], +) +test('runtest-ccpp', exe) |