diff options
| author | Xavier Claessens <xavier.claessens@collabora.com> | 2020-11-03 09:39:39 -0500 |
|---|---|---|
| committer | Nirbheek Chauhan <nirbheek@centricular.com> | 2021-01-06 14:51:12 +0530 |
| commit | b17972d4bf8f3fff54b3bb9ada5b2c9e7ccbc35b (patch) | |
| tree | c2b7e0d7d8dbec8c6a42f4e29a42a874030d848c | |
| parent | d38ef1d2e6edd81d45203331fdcce09baca58e6b (diff) | |
| download | meson-b17972d4bf8f3fff54b3bb9ada5b2c9e7ccbc35b.zip meson-b17972d4bf8f3fff54b3bb9ada5b2c9e7ccbc35b.tar.gz meson-b17972d4bf8f3fff54b3bb9ada5b2c9e7ccbc35b.tar.bz2 | |
pkgconfig: Make external deps of static library public
This fix a regression caused by
https://github.com/mesonbuild/meson/pull/7837, it wanted to make
InternalDependency's external_deps private but has side effect of making
StatisLibrary's external_deps private too.
It is technically correct to make them private, but Meson used to make
StaticLibrary deps public so they are usable without `pkg-config
--static` when we know there is only a static library available.
Fixes: #7929.
| -rw-r--r-- | mesonbuild/modules/pkgconfig.py | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/mesonbuild/modules/pkgconfig.py b/mesonbuild/modules/pkgconfig.py index a863b33..62e1c15 100644 --- a/mesonbuild/modules/pkgconfig.py +++ b/mesonbuild/modules/pkgconfig.py @@ -131,7 +131,7 @@ class DependenciesHelper: if obj.found(): processed_libs += obj.get_link_args() processed_cflags += obj.get_compile_args() - self._add_lib_dependencies(obj.libraries, obj.whole_libraries, obj.ext_deps, public) + self._add_lib_dependencies(obj.libraries, obj.whole_libraries, obj.ext_deps, public, private_external_deps=True) elif isinstance(obj, dependencies.Dependency): if obj.found(): processed_libs += obj.get_link_args() @@ -160,7 +160,7 @@ class DependenciesHelper: return processed_libs, processed_reqs, processed_cflags - def _add_lib_dependencies(self, link_targets, link_whole_targets, external_deps, public): + def _add_lib_dependencies(self, link_targets, link_whole_targets, external_deps, public, private_external_deps=False): add_libs = self.add_pub_libs if public else self.add_priv_libs # Recursively add all linked libraries for t in link_targets: @@ -173,7 +173,10 @@ class DependenciesHelper: for t in link_whole_targets: self._add_link_whole(t, public) # And finally its external dependencies - self.add_priv_libs(external_deps) + if private_external_deps: + self.add_priv_libs(external_deps) + else: + add_libs(external_deps) def _add_link_whole(self, t, public): # Don't include static libraries that we link_whole. But we still need to |