From e5e6df7c37f7de13af33a3096e9c66127bb75d15 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Thu, 9 Jul 2015 13:47:19 +1000 Subject: fdtdump: Fix bug printing bytestrings with negative values On systems where 'char' is signed, fdtdump will currently print the wrong thing on properties containing bytestring values with "negative" bytes (that is with values from 0x80..0xff). The fdtdump testcase is extended to cover this case too. This corrects the problem by forcing use of unsigned char - although this is perhaps another indication that fdtdump is a buggy hack and if you want to do real work you should use dtc -O dts. Reported-by: Igor Prusov Signed-off-by: David Gibson --- util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'util.c') diff --git a/util.c b/util.c index 9d65226..cbb945b 100644 --- a/util.c +++ b/util.c @@ -349,7 +349,6 @@ int utilfdt_decode_type(const char *fmt, int *type, int *size) void utilfdt_print_data(const char *data, int len) { int i; - const char *p = data; const char *s; /* no data, don't print */ @@ -376,6 +375,7 @@ void utilfdt_print_data(const char *data, int len) i < (len - 1) ? " " : ""); printf(">"); } else { + const unsigned char *p = (const unsigned char *)data; printf(" = ["); for (i = 0; i < len; i++) printf("%02x%s", *p++, i < len - 1 ? " " : ""); -- cgit v1.1