diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2008-06-26 11:03:49 +1000 |
|---|---|---|
| committer | Jon Loeliger <jdl@jdl.com> | 2008-07-14 12:21:18 -0500 |
| commit | cdcb415851dc6c3e9550f27139c933fcaeb2d6a7 (patch) | |
| tree | fa9aa48cba4c6e6759a63433c1ef0fdf63b5a488 /tests/testdata.h | |
| parent | 11d7100ee5de7d6a6c4a76b735a1e624fbe8466a (diff) | |
| download | dtc-cdcb415851dc6c3e9550f27139c933fcaeb2d6a7.zip dtc-cdcb415851dc6c3e9550f27139c933fcaeb2d6a7.tar.gz dtc-cdcb415851dc6c3e9550f27139c933fcaeb2d6a7.tar.bz2 | |
dtc: Address an assortment of portability problems
I've recently worked with a FreeBSD developer, getting dtc and libfdt
working on FreeBSD. This showed up a number of portability problems
in the dtc package which this patch addresses. Changes are as
follows:
- the parent_offset and supernode_atdepth_offset testcases
used the glibc extension functions strchrnul() and strndupa(). Those
are removed, using slightly longer coding with standard C functions
instead.
- some other testcases had a #define _GNU_SOURCE for no
particular reason. This is removed.
- run_tests.sh has bash specific constructs removed, and the
interpreter changed to /bin/sh. This apparently now runs fine on
FreeBSD's /bin/sh, and I've also tested it with both ash and dash.
- convert-dtsv0-lexer.l has some extra #includes added. These
must have been included indirectly with Linux and glibc, but aren't on
FreeBSD.
- the endian handling functions in libfdt_env.h, based on
endian.h and byteswap.h are replaced with some portable open-coded
versions. Unfortunately, these result in fairly crappy code when
compiled, but as far as I can determine there doesn't seem to be any
POSIX, SUS or de facto standard way of determining endianness at
compile time, nor standard names for byteswapping functions.
- some more endian handling, from testdata.h using the
problematic endian.h is simply removed, since it wasn't actually being
used anyway.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'tests/testdata.h')
| -rw-r--r-- | tests/testdata.h | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/tests/testdata.h b/tests/testdata.h index 9c8b040..5b5a9a3 100644 --- a/tests/testdata.h +++ b/tests/testdata.h @@ -1,14 +1,3 @@ -#include <endian.h> - -#if __BYTE_ORDER == __BIG_ENDIAN -#define cell_to_fdt(x) (x) -#else -/* We do this as a big hairy expression instead of using bswap_32() - * because we need it to work in asm as well as C. */ -#define cell_to_fdt(x) ((((x) >> 24) & 0xff) | (((x) >> 8) & 0xff00) \ - | (((x) << 8) & 0xff0000) | (((x) << 24) & 0xff000000)) -#endif - #ifdef __ASSEMBLY__ #define ASM_CONST_LL(x) (x) #else |