From 311a01068d71a4b3e8eb3d3c00eaa156b55c2314 Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Wed, 2 Oct 2024 16:37:08 +0200 Subject: tests/tcg/plugins: Remove remainder of the cris target MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The cris target has recently been removed (see commit 44e4075bf4 - "target/cris: Remove the deprecated CRIS target"), but apparently this line has been forgotten. So clean it up now. Signed-off-by: Thomas Huth Reviewed-by: Alex Bennée Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- tests/tcg/plugins/syscall.c | 1 - 1 file changed, 1 deletion(-) (limited to 'tests') diff --git a/tests/tcg/plugins/syscall.c b/tests/tcg/plugins/syscall.c index 89dc7f4..ff45217 100644 --- a/tests/tcg/plugins/syscall.c +++ b/tests/tcg/plugins/syscall.c @@ -34,7 +34,6 @@ static const struct SyscallInfo arch_syscall_info[] = { { "arm", 4 }, { "armeb", 4 }, { "avr", -1 }, - { "cris", -1 }, { "hexagon", 64 }, { "hppa", -1 }, { "i386", 4 }, -- cgit v1.1 From db17daf8c43a321f62f8bc46ea0f4a76e16b386f Mon Sep 17 00:00:00 2001 From: Thomas Huth Date: Fri, 4 Oct 2024 15:02:25 +0200 Subject: tests/functional: Fix hash validation The _check() function is supposed to check whether the hash of the downloaded file matches the expected one. Unfortunately, during the last rework of this function, the check was accidentally turned into returning the hash value itself instead of a True/False value, effectively accepting each hash as valid. Let's do a proper check again now. Fixes:05e303210d ("tests/functional/qemu_test: Use Python hashlib ...") Signed-off-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- tests/functional/qemu_test/asset.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_test/asset.py index 3ec4292..e47bfac 100644 --- a/tests/functional/qemu_test/asset.py +++ b/tests/functional/qemu_test/asset.py @@ -57,7 +57,7 @@ class Asset: break hl.update(chunk) - return hl.hexdigest() + return self.hash == hl.hexdigest() def valid(self): return self.cache_file.exists() and self._check(self.cache_file) -- cgit v1.1