From 1266c9b9f5fa05877b979eece5963a2bd99c3bfd Mon Sep 17 00:00:00 2001 From: Kevin Wolf Date: Thu, 24 May 2018 15:26:10 +0200 Subject: job: Add error message for failing jobs So far we relied on job->ret and strerror() to produce an error message for failed jobs. Not surprisingly, this tends to result in completely useless messages. This adds a Job.error field that can contain an error string for a failing job, and a parameter to job_completed() that sets the field. As a default, if NULL is passed, we continue to use strerror(job->ret). All existing callers are changed to pass NULL. They can be improved in separate patches. Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Jeff Cody --- tests/test-blockjob-txn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/test-blockjob-txn.c') diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c index fce8366..58d9b87 100644 --- a/tests/test-blockjob-txn.c +++ b/tests/test-blockjob-txn.c @@ -34,7 +34,7 @@ static void test_block_job_complete(Job *job, void *opaque) rc = -ECANCELED; } - job_completed(job, rc); + job_completed(job, rc, NULL); bdrv_unref(bs); } -- cgit v1.1