From 501093207eb1ed4845e0a65ee1ce7db7b9676e0b Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Wed, 23 Sep 2020 11:12:17 +0200 Subject: module: silence errors for module_load_qom_all(). Add mayfail bool parameter to module loading functions. Set it to true for module_load_qom_all() because device modules might not load into all system emulation variants. qemu-system-s390x for example will not load qxl because it lacks vga support. Makes "make check" less chatty. Drop module_loaded_qom_all check in module_load_qom_one to make sure we see errors for explicit load requests, i.e. module_load_qom_one("qxl") failing will log an error no matter whenever module_load_qom_all() was called before or not. Signed-off-by: Gerd Hoffmann Acked-by: Paolo Bonzini Message-id: 20200923091217.22662-1-kraxel@redhat.com --- softmmu/qtest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'softmmu') diff --git a/softmmu/qtest.c b/softmmu/qtest.c index 2c6e8dc..7965dc9 100644 --- a/softmmu/qtest.c +++ b/softmmu/qtest.c @@ -757,7 +757,7 @@ static void qtest_process_command(CharBackend *chr, gchar **words) g_assert(words[1] && words[2]); qtest_send_prefix(chr); - if (module_load_one(words[1], words[2])) { + if (module_load_one(words[1], words[2], false)) { qtest_sendf(chr, "OK\n"); } else { qtest_sendf(chr, "FAIL\n"); -- cgit v1.1