From 06831001ac8949b0801e0d20c347d97339769a20 Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Fri, 3 Mar 2023 14:37:51 +0100 Subject: atomics: eliminate mb_read/mb_set qatomic_mb_read and qatomic_mb_set were the very first atomic primitives introduced for QEMU; their semantics are unclear and they provide a false sense of safety. The last use of qatomic_mb_read() has been removed, so delete it. qatomic_mb_set() instead can survive as an optimized qatomic_set()+smp_mb(), similar to Linux's smp_store_mb(), but rename it to qatomic_set_mb() to match the order of the two operations. Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- softmmu/physmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'softmmu/physmem.c') diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 9d7e172..588d0d1 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @@ -3132,7 +3132,7 @@ void address_space_unmap(AddressSpace *as, void *buffer, hwaddr len, bounce.buffer = NULL; memory_region_unref(bounce.mr); /* Clear in_use before reading map_client_list. */ - qatomic_mb_set(&bounce.in_use, false); + qatomic_set_mb(&bounce.in_use, false); cpu_notify_map_clients(); } -- cgit v1.1