From 3df04ac3c63ba6a0ff7417e0f7dd389bc3efb09d Mon Sep 17 00:00:00 2001 From: Mark McLoughlin Date: Wed, 23 Sep 2009 11:24:05 +0100 Subject: Fix coding style issue Replace: if (-1 == foo()) with: if (foo() == -1) While this coding style is not in direct contravention of our currently ratified CODING_STYLE treaty, it could be argued that the Article 3 of the European Convention on Human Rights (prohibiting torture and "inhuman or degrading treatment") reads on the matter. [This commit message was brought to you without humour, as is evidenced by the absence of any emoticons] Signed-off-by: Mark McLoughlin Cc: Avi Kivity Cc: Gerd Hoffmann Signed-off-by: Blue Swirl --- qemu-option.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'qemu-option.c') diff --git a/qemu-option.c b/qemu-option.c index 88298e4..9fe1f95 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -267,7 +267,7 @@ int set_option_parameter(QEMUOptionParameter *list, const char *name, // Process parameter switch (list->type) { case OPT_FLAG: - if (-1 == parse_option_bool(name, value, &flag)) + if (parse_option_bool(name, value, &flag) == -1) return -1; list->value.n = flag; break; @@ -282,7 +282,7 @@ int set_option_parameter(QEMUOptionParameter *list, const char *name, break; case OPT_SIZE: - if (-1 == parse_option_size(name, value, &list->value.n)) + if (parse_option_size(name, value, &list->value.n) == -1) return -1; break; @@ -745,7 +745,7 @@ int qemu_opts_do_parse(QemuOpts *opts, const char *params, const char *firstname } if (strcmp(option, "id") != 0) { /* store and parse */ - if (-1 == qemu_opt_set(opts, option, value)) { + if (qemu_opt_set(opts, option, value) == -1) { return -1; } } -- cgit v1.1