From 80b857f0c6399570c5db06422d8b96690b522580 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Thu, 19 Oct 2017 15:28:47 +0100 Subject: ui: normalize the 'sysrq' key into the 'print' key The 'sysrq' key was mistakenly added to QEMU to deal with incorrect handling of the 'print' key in the ps2 device: commit f2289cb6924afc97b2a75d21bfc9217024d11741 Author: balrog Date: Wed Jun 4 10:14:16 2008 +0000 Add sysrq to key names known by "sendkey". Adding sysrq keycode to the table enabling running sysrq debugging in the guest via the monitor sendkey command, like: (qemu) sendkey alt-sysrq-t Tested on x86-64 target and Linux guest. Signed-off-by: Ryan Harper The ps2 device is now fixed wrt modifiers and the 'print' key. Further the handling of the 'sysrq' key has some problems of its own, documented in the previous commit. To cleanup this mess, we convert any use of 'sysrq' into 'print' prior to dispatching the event to device models. Signed-off-by: Daniel P. Berrange Message-id: 20171019142848.572-9-berrange@redhat.com Signed-off-by: Gerd Hoffmann --- qapi/ui.json | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'qapi/ui.json') diff --git a/qapi/ui.json b/qapi/ui.json index e5d6610..07b468f 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -748,6 +748,13 @@ # @ac_bookmarks: since 2.10 # altgr, altgr_r: dropped in 2.10 # +# 'sysrq' was mistakenly added to hack around the fact that +# the ps2 driver was not generating correct scancodes sequences +# when 'alt+print' was pressed. This flaw is now fixed and the +# 'sysrq' key serves no further purpose. Any further use of +# 'sysrq' will be transparently changed to 'print', so they +# are effectively synonyms. +# # Since: 1.3.0 # ## -- cgit v1.1