From 73af8dd8d75a3e1f13e6c5d2a509fa56eb406519 Mon Sep 17 00:00:00 2001 From: Juan Quintela Date: Thu, 5 Oct 2017 21:30:10 +0200 Subject: migration: Make xbzrle_cache_size a migration parameter Right now it is a variable in MigrationState instead of a MigrationParameter. The change allows to set it as the rest of the Migration parameters, from the command line, with query_migration_paramters, set_migrate_parameters, etc. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- qapi/migration.json | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) (limited to 'qapi/migration.json') diff --git a/qapi/migration.json b/qapi/migration.json index 6ae866e..bbc4671 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -483,6 +483,11 @@ # @x-multifd-page-count: Number of pages sent together to a thread. # The default value is 16 (since 2.11) # +# @xbzrle-cache-size: cache size to be used by XBZRLE migration. It +# needs to be a multiple of the target page size +# and a power of 2 +# (Since 2.11) +# # Since: 2.4 ## { 'enum': 'MigrationParameter', @@ -490,7 +495,8 @@ 'cpu-throttle-initial', 'cpu-throttle-increment', 'tls-creds', 'tls-hostname', 'max-bandwidth', 'downtime-limit', 'x-checkpoint-delay', 'block-incremental', - 'x-multifd-channels', 'x-multifd-page-count' ] } + 'x-multifd-channels', 'x-multifd-page-count', + 'xbzrle-cache-size' ] } ## # @MigrateSetParameters: @@ -554,6 +560,10 @@ # @x-multifd-page-count: Number of pages sent together to a thread. # The default value is 16 (since 2.11) # +# @xbzrle-cache-size: cache size to be used by XBZRLE migration. It +# needs to be a multiple of the target page size +# and a power of 2 +# (Since 2.11) # Since: 2.4 ## # TODO either fuse back into MigrationParameters, or make @@ -571,7 +581,8 @@ '*x-checkpoint-delay': 'int', '*block-incremental': 'bool', '*x-multifd-channels': 'int', - '*x-multifd-page-count': 'int' } } + '*x-multifd-page-count': 'int', + '*xbzrle-cache-size': 'size' } } ## # @migrate-set-parameters: @@ -650,6 +661,10 @@ # @x-multifd-page-count: Number of pages sent together to a thread. # The default value is 16 (since 2.11) # +# @xbzrle-cache-size: cache size to be used by XBZRLE migration. It +# needs to be a multiple of the target page size +# and a power of 2 +# (Since 2.11) # Since: 2.4 ## { 'struct': 'MigrationParameters', @@ -665,7 +680,8 @@ '*x-checkpoint-delay': 'int', '*block-incremental': 'bool' , '*x-multifd-channels': 'int', - '*x-multifd-page-count': 'int' } } + '*x-multifd-page-count': 'int', + '*xbzrle-cache-size': 'size' } } ## # @query-migrate-parameters: @@ -947,6 +963,8 @@ # # Returns: nothing on success # +# Notes: This command is deprecated in favor of 'migrate-set-parameters' +# # Since: 1.2 # # Example: @@ -965,6 +983,8 @@ # # Returns: XBZRLE cache size in bytes # +# Notes: This command is deprecated in favor of 'query-migrate-parameters' +# # Since: 1.2 # # Example: -- cgit v1.1