From ecaf54a052c357e0bacb93c3f178fed34e4821ec Mon Sep 17 00:00:00 2001 From: Chen Fan Date: Mon, 18 Aug 2014 14:46:35 +0800 Subject: hmp: fix MemdevList memory leak the memdev_list in hmp_info_memdev() is never freed. so we use existent method qapi_free_MemdevList() to free it. and also we can use qapi_free_MemdevList() to replace list loops to clean up the memdev list in error path. Signed-off-by: Chen Fan Reviewed-by: Peter Crosthwaite Reviewed-by: Hu Tao Signed-off-by: Michael Tokarev --- numa.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'numa.c') diff --git a/numa.c b/numa.c index aa772aa..f07149b 100644 --- a/numa.c +++ b/numa.c @@ -379,7 +379,7 @@ error: MemdevList *qmp_query_memdev(Error **errp) { Object *obj; - MemdevList *list = NULL, *m; + MemdevList *list = NULL; obj = object_resolve_path("/objects", NULL); if (obj == NULL) { @@ -393,11 +393,6 @@ MemdevList *qmp_query_memdev(Error **errp) return list; error: - while (list) { - m = list; - list = list->next; - g_free(m->value); - g_free(m); - } + qapi_free_MemdevList(list); return NULL; } -- cgit v1.1