From 5bee0f4717c4c67394aaade0c5a9cee3d42cc614 Mon Sep 17 00:00:00 2001 From: Eric Blake Date: Thu, 21 Jul 2016 13:34:45 -0600 Subject: nbd: Fix bad flag detection on server Commit ab7c548e added a check for invalid flags, but used an early return on error instead of properly going through the cleanup label. Signed-off-by: Eric Blake Message-Id: <1469129688-22848-2-git-send-email-eblake@redhat.com> Signed-off-by: Paolo Bonzini --- nbd/server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'nbd') diff --git a/nbd/server.c b/nbd/server.c index 29e2099..3c1e2b3 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -1057,7 +1057,8 @@ static ssize_t nbd_co_receive_request(NBDRequest *req, if (request->type & ~NBD_CMD_MASK_COMMAND & ~NBD_CMD_FLAG_FUA) { LOG("unsupported flags (got 0x%x)", request->type & ~NBD_CMD_MASK_COMMAND); - return -EINVAL; + rc = -EINVAL; + goto out; } rc = 0; -- cgit v1.1