From 902f6e14fc68743ce24efb7d87dc3f8464a78bf3 Mon Sep 17 00:00:00 2001 From: Ross Lagerwall Date: Wed, 1 Nov 2017 14:25:24 +0000 Subject: io: Fix QIOChannelFile when creating and opening read-write The code wrongly passes the mode to open() only if O_WRONLY is set. Instead, the mode should be passed when O_CREAT is set (or O_TMPFILE on Linux). Fix this by always passing the mode since open() will correctly ignore the mode if it is not needed. Add a testcase which exercises this bug and also change the existing testcase to check that the mode of the created file is correct. Signed-off-by: Ross Lagerwall Signed-off-by: Daniel P. Berrange --- include/io/channel-file.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'include/io/channel-file.h') diff --git a/include/io/channel-file.h b/include/io/channel-file.h index 79245f1..ebfe54e 100644 --- a/include/io/channel-file.h +++ b/include/io/channel-file.h @@ -73,7 +73,7 @@ qio_channel_file_new_fd(int fd); * qio_channel_file_new_path: * @path: the file path * @flags: the open flags (O_RDONLY|O_WRONLY|O_RDWR, etc) - * @mode: the file creation mode if O_WRONLY is set in @flags + * @mode: the file creation mode if O_CREAT is set in @flags * @errp: pointer to initialized error object * * Create a new IO channel object for a file represented -- cgit v1.1