From ca44141d5fb801dd5903102acefd0f2d8e8bb6a1 Mon Sep 17 00:00:00 2001 From: Ashijeet Acharya Date: Tue, 27 Sep 2016 22:23:32 +0530 Subject: ide: Fix memory leak in ide_register_restart_cb() Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash. Signed-off-by: Ashijeet Acharya Reviewed-by: John Snow Message-id: 1474995212-10580-1-git-send-email-ashijeetacharya@gmail.com [Minor whitespace fix --js] Signed-off-by: John Snow --- include/hw/ide/internal.h | 1 + 1 file changed, 1 insertion(+) (limited to 'include/hw/ide') diff --git a/include/hw/ide/internal.h b/include/hw/ide/internal.h index a6dd2c3..88dc118 100644 --- a/include/hw/ide/internal.h +++ b/include/hw/ide/internal.h @@ -482,6 +482,7 @@ struct IDEBus { uint32_t retry_nsector; PortioList portio_list; PortioList portio2_list; + VMChangeStateEntry *vmstate; }; #define TYPE_IDE_DEVICE "ide-device" -- cgit v1.1