From 81a322d4a1b68d47908a6630bf22897a289722aa Mon Sep 17 00:00:00 2001 From: Gerd Hoffmann Date: Fri, 14 Aug 2009 10:36:05 +0200 Subject: qdev: add return value to init() callbacks. Sorry folks, but it has to be. One more of these invasive qdev patches. We have a serious design bug in the qdev interface: device init callbacks can't signal failure because the init() callback has no return value. This patch fixes it. We have already one case in-tree where this is needed: Try -device virtio-blk-pci (without drive= specified) and watch qemu segfault. This patch fixes it. With usb+scsi being converted to qdev we'll get more devices where the init callback can fail for various reasons. Signed-off-by: Gerd Hoffmann Signed-off-by: Anthony Liguori --- hw/syborg_pointer.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'hw/syborg_pointer.c') diff --git a/hw/syborg_pointer.c b/hw/syborg_pointer.c index 5bd44f4..563d730 100644 --- a/hw/syborg_pointer.c +++ b/hw/syborg_pointer.c @@ -199,7 +199,7 @@ static int syborg_pointer_load(QEMUFile *f, void *opaque, int version_id) return 0; } -static void syborg_pointer_init(SysBusDevice *dev) +static int syborg_pointer_init(SysBusDevice *dev) { SyborgPointerState *s = FROM_SYSBUS(SyborgPointerState, dev); int iomemtype; @@ -220,6 +220,7 @@ static void syborg_pointer_init(SysBusDevice *dev) register_savevm("syborg_pointer", -1, 1, syborg_pointer_save, syborg_pointer_load, s); + return 0; } static SysBusDeviceInfo syborg_pointer_info = { -- cgit v1.1