From ba50822ff835c197563423b688afc6d0fe50f7d0 Mon Sep 17 00:00:00 2001 From: David Gibson Date: Thu, 13 Jul 2017 10:52:39 +1000 Subject: spapr: Abort on delete failure in spapr_drc_release() We currently ignore errors from the object_property_del() in spapr_drc_release(). But the only way that could fail is if the property doesn't exist, in which case it's a bug that we're in spapr_drc_release() at all. So change from ignoring to abort()ing on errors. Signed-off-by: David Gibson --- hw/ppc/spapr_drc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hw/ppc') diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 7f872a4..fd56140 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -367,7 +367,7 @@ static void spapr_drc_release(sPAPRDRConnector *drc) g_free(drc->fdt); drc->fdt = NULL; drc->fdt_start_offset = 0; - object_property_del(OBJECT(drc), "device", NULL); + object_property_del(OBJECT(drc), "device", &error_abort); drc->dev = NULL; } -- cgit v1.1