From e221cfac5935b0fea0989da9ef4ee5024777f23e Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Thu, 1 Dec 2022 13:11:33 +0100 Subject: pci: Reject pcie_aer_inject_error -c with symbolic error status When argument @error_status is symbolic, flag -c is ignored. Reject it instead. Signed-off-by: Markus Armbruster Message-Id: <20221201121133.3813857-14-armbru@redhat.com> --- hw/pci/pci-hmp-cmds.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'hw/pci') diff --git a/hw/pci/pci-hmp-cmds.c b/hw/pci/pci-hmp-cmds.c index a292d06..fb7591d 100644 --- a/hw/pci/pci-hmp-cmds.c +++ b/hw/pci/pci-hmp-cmds.c @@ -189,6 +189,11 @@ void hmp_pcie_aer_inject_error(Monitor *mon, const QDict *qdict) } error_status = num; correctable = qdict_get_try_bool(qdict, "correctable", false); + } else { + if (qdict_haskey(qdict, "correctable")) { + error_setg(&err, "-c is only valid with numeric error status"); + goto out; + } } aer_err.status = error_status; aer_err.source_id = pci_requester_id(dev); -- cgit v1.1