From 7797a73947d5c0e63dd5552b348cf66c384b4555 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Fri, 24 Oct 2014 12:19:11 +0100 Subject: hmp: Remove "info pcmcia" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This command lists PCMCIA sockets and cards. Only a few ARM boards have sockets (akita, borzoi, connex, mainstone, spitz, terrier, tosa, verdex, z2), the only card is the DSCM-1xxxx Hitachi Microdrive (qdev "microdrive"), and it is only inserted during machine init, if ever. So this command doesn't really tell anybody anything new so far. Moreover, pcmcia_socket_unregister() has a use-after-free bug, flagged by Coverity. Has never been used, because there has never been code to eject a PCMCIA card. Not worth fixing & converting to QMP. Remove it. Signed-off-by: Markus Armbruster Acked-by: Luiz Capitulino Acked-by: Andreas Färber Message-id: 1411144812-22958-1-git-send-email-armbru@redhat.com Signed-off-by: Peter Maydell --- hw/ide/microdrive.c | 1 - 1 file changed, 1 deletion(-) (limited to 'hw/ide/microdrive.c') diff --git a/hw/ide/microdrive.c b/hw/ide/microdrive.c index ed85185..6639dd4 100644 --- a/hw/ide/microdrive.c +++ b/hw/ide/microdrive.c @@ -543,7 +543,6 @@ static int dscm1xxxx_attach(PCMCIACardState *card) device_reset(DEVICE(md)); md_interrupt_update(md); - card->slot->card_string = "DSCM-1xxxx Hitachi Microdrive"; return 0; } -- cgit v1.1