From bce544740a87cac1636f01c8a28502fec1694b3d Mon Sep 17 00:00:00 2001 From: Paolo Bonzini Date: Wed, 28 Mar 2012 18:12:47 +0200 Subject: qdev: Move bus properties to abstract superclasses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In qdev, each bus in practice identified an abstract superclass, but this was mostly hidden. In QOM, instead, these abstract classes are explicit so we can move bus properties there. All bus property walks are removed, and all device property walks are changed to look along the class hierarchy instead. We would have duplicates if class A defines some properties and its subclass B does not define any, because class_b->props will be left equal to class_a->props. The solution here is to reintroduce the class_base_init TypeInfo callback, that was present in one of the early QOM versions but removed (on my request...) before committing. This breaks global bus properties, an obscure feature when used with the command-line which is actually useful and used when used by backwards-compatible machine types. So this patch also adjusts the global bus properties in hw/pc_piix.c to refer to the abstract class. Globals and other properties must be modified in the same patch to avoid complications related to initialization ordering. Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'hw/i2c.c') diff --git a/hw/i2c.c b/hw/i2c.c index cb10b1d..af5979e 100644 --- a/hw/i2c.c +++ b/hw/i2c.c @@ -25,7 +25,6 @@ static Property i2c_props[] = { static struct BusInfo i2c_bus_info = { .name = "I2C", .size = sizeof(i2c_bus), - .props = i2c_props, }; static void i2c_bus_pre_save(void *opaque) @@ -221,6 +220,7 @@ static void i2c_slave_class_init(ObjectClass *klass, void *data) DeviceClass *k = DEVICE_CLASS(klass); k->init = i2c_slave_qdev_init; k->bus_info = &i2c_bus_info; + k->props = i2c_props; } static TypeInfo i2c_slave_type_info = { -- cgit v1.1