From a27bd6c779badb8d76e4430d810ef710a1b98f4e Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 12 Aug 2019 07:23:51 +0200 Subject: Include hw/qdev-properties.h less MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In my "build everything" tree, changing hw/qdev-properties.h triggers a recompile of some 2700 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). Many places including hw/qdev-properties.h (directly or via hw/qdev.h) actually need only hw/qdev-core.h. Include hw/qdev-core.h there instead. hw/qdev.h is actually pointless: all it does is include hw/qdev-core.h and hw/qdev-properties.h, which in turn includes hw/qdev-core.h. Replace the remaining uses of hw/qdev.h by hw/qdev-properties.h. While there, delete a few superfluous inclusions of hw/qdev-core.h. Touching hw/qdev-properties.h now recompiles some 1200 objects. Cc: Paolo Bonzini Cc: "Daniel P. Berrangé" Cc: Eduardo Habkost Signed-off-by: Markus Armbruster Reviewed-by: Eduardo Habkost Message-Id: <20190812052359.30071-22-armbru@redhat.com> --- hw/display/ati.c | 1 + hw/display/bcm2835_fb.c | 1 + hw/display/bochs-display.c | 1 + hw/display/cg3.c | 1 + hw/display/cirrus_vga.c | 1 + hw/display/cirrus_vga_isa.c | 1 + hw/display/g364fb.c | 1 + hw/display/i2c-ddc.c | 1 + hw/display/milkymist-vgafb.c | 1 + hw/display/qxl.c | 1 + hw/display/ramfb-standalone.c | 1 + hw/display/sm501.c | 1 + hw/display/tcx.c | 1 + hw/display/vga-isa.c | 1 + hw/display/vga-pci.c | 1 + hw/display/vhost-user-gpu.c | 1 + hw/display/virtio-gpu-pci.c | 1 + hw/display/virtio-gpu.c | 1 + hw/display/virtio-vga.c | 1 + hw/display/vmware_vga.c | 1 + 20 files changed, 20 insertions(+) (limited to 'hw/display') diff --git a/hw/display/ati.c b/hw/display/ati.c index df978a4..35f49a5 100644 --- a/hw/display/ati.c +++ b/hw/display/ati.c @@ -19,6 +19,7 @@ #include "qemu/osdep.h" #include "ati_int.h" #include "ati_regs.h" +#include "hw/qdev-properties.h" #include "vga_regs.h" #include "qemu/log.h" #include "qemu/module.h" diff --git a/hw/display/bcm2835_fb.c b/hw/display/bcm2835_fb.c index e606893..8f85687 100644 --- a/hw/display/bcm2835_fb.c +++ b/hw/display/bcm2835_fb.c @@ -31,6 +31,7 @@ #include "framebuffer.h" #include "ui/pixel_ops.h" #include "hw/misc/bcm2835_mbox_defs.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/module.h" diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c index 1ddba5b..dc1bd16 100644 --- a/hw/display/bochs-display.c +++ b/hw/display/bochs-display.c @@ -9,6 +9,7 @@ #include "qemu/module.h" #include "qemu/units.h" #include "hw/pci/pci.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "hw/display/bochs-vbe.h" #include "hw/display/edid.h" diff --git a/hw/display/cg3.c b/hw/display/cg3.c index 29a8735..f90baae 100644 --- a/hw/display/cg3.c +++ b/hw/display/cg3.c @@ -32,6 +32,7 @@ #include "migration/vmstate.h" #include "hw/irq.h" #include "hw/loader.h" +#include "hw/qdev-properties.h" #include "qemu/log.h" #include "qemu/module.h" diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 0f5465b..cd283e5 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga.c @@ -39,6 +39,7 @@ #include "qapi/error.h" #include "trace.h" #include "hw/pci/pci.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "ui/pixel_ops.h" #include "cirrus_vga_internal.h" diff --git a/hw/display/cirrus_vga_isa.c b/hw/display/cirrus_vga_isa.c index 49f409b..7ef8e59 100644 --- a/hw/display/cirrus_vga_isa.c +++ b/hw/display/cirrus_vga_isa.c @@ -27,6 +27,7 @@ #include "qapi/error.h" #include "qemu/module.h" #include "hw/loader.h" +#include "hw/qdev-properties.h" #include "hw/isa/isa.h" #include "cirrus_vga_internal.h" diff --git a/hw/display/g364fb.c b/hw/display/g364fb.c index 1757b77..839d26e 100644 --- a/hw/display/g364fb.c +++ b/hw/display/g364fb.c @@ -21,6 +21,7 @@ #include "qemu/units.h" #include "hw/hw.h" #include "hw/irq.h" +#include "hw/qdev-properties.h" #include "qemu/error-report.h" #include "qemu/module.h" #include "ui/console.h" diff --git a/hw/display/i2c-ddc.c b/hw/display/i2c-ddc.c index 3ac8521..fc70b79 100644 --- a/hw/display/i2c-ddc.c +++ b/hw/display/i2c-ddc.c @@ -20,6 +20,7 @@ #include "qemu/log.h" #include "qemu/module.h" #include "hw/i2c/i2c.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "hw/display/i2c-ddc.h" diff --git a/hw/display/milkymist-vgafb.c b/hw/display/milkymist-vgafb.c index 9a9a481..8b0da46 100644 --- a/hw/display/milkymist-vgafb.c +++ b/hw/display/milkymist-vgafb.c @@ -24,6 +24,7 @@ #include "qemu/osdep.h" #include "hw/hw.h" +#include "hw/qdev-properties.h" #include "hw/sysbus.h" #include "trace.h" #include "ui/console.h" diff --git a/hw/display/qxl.c b/hw/display/qxl.c index 539ede1..971c2d0 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -29,6 +29,7 @@ #include "qemu/main-loop.h" #include "qemu/module.h" #include "sysemu/sysemu.h" +#include "hw/qdev-properties.h" #include "migration/blocker.h" #include "migration/vmstate.h" #include "trace.h" diff --git a/hw/display/ramfb-standalone.c b/hw/display/ramfb-standalone.c index 56215ef..ebd623a 100644 --- a/hw/display/ramfb-standalone.c +++ b/hw/display/ramfb-standalone.c @@ -2,6 +2,7 @@ #include "qapi/error.h" #include "qemu/module.h" #include "hw/loader.h" +#include "hw/qdev-properties.h" #include "hw/isa/isa.h" #include "hw/display/ramfb.h" #include "ui/console.h" diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 6033963..d9e5762 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -34,6 +34,7 @@ #include "hw/sysbus.h" #include "migration/vmstate.h" #include "hw/pci/pci.h" +#include "hw/qdev-properties.h" #include "hw/i2c/i2c.h" #include "hw/display/i2c-ddc.h" #include "qemu/range.h" diff --git a/hw/display/tcx.c b/hw/display/tcx.c index f9b1ae5..14e829d 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -28,6 +28,7 @@ #include "ui/console.h" #include "ui/pixel_ops.h" #include "hw/loader.h" +#include "hw/qdev-properties.h" #include "hw/sysbus.h" #include "migration/vmstate.h" #include "qemu/error-report.h" diff --git a/hw/display/vga-isa.c b/hw/display/vga-isa.c index 189a4af..873e5e9 100644 --- a/hw/display/vga-isa.c +++ b/hw/display/vga-isa.c @@ -31,6 +31,7 @@ #include "qemu/module.h" #include "qemu/timer.h" #include "hw/loader.h" +#include "hw/qdev-properties.h" #define TYPE_ISA_VGA "isa-vga" #define ISA_VGA(obj) OBJECT_CHECK(ISAVGAState, (obj), TYPE_ISA_VGA) diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c index 86299f5..a27b881 100644 --- a/hw/display/vga-pci.c +++ b/hw/display/vga-pci.c @@ -26,6 +26,7 @@ #include "qemu/osdep.h" #include "hw/pci/pci.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #include "vga_int.h" #include "ui/pixel_ops.h" diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c index 7181d9c..2798778 100644 --- a/hw/display/vhost-user-gpu.c +++ b/hw/display/vhost-user-gpu.c @@ -11,6 +11,7 @@ */ #include "qemu/osdep.h" +#include "hw/qdev-properties.h" #include "hw/virtio/virtio-gpu.h" #include "chardev/char-fe.h" #include "qapi/error.h" diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c index e4c7eb6..25e4038 100644 --- a/hw/display/virtio-gpu-pci.c +++ b/hw/display/virtio-gpu-pci.c @@ -15,6 +15,7 @@ #include "qapi/error.h" #include "qemu/module.h" #include "hw/pci/pci.h" +#include "hw/qdev-properties.h" #include "hw/virtio/virtio.h" #include "hw/virtio/virtio-bus.h" #include "hw/virtio/virtio-gpu-pci.h" diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index ed92071..6de9689 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -24,6 +24,7 @@ #include "hw/virtio/virtio-gpu-pixman.h" #include "hw/virtio/virtio-bus.h" #include "hw/display/edid.h" +#include "hw/qdev-properties.h" #include "qemu/log.h" #include "qemu/module.h" #include "qapi/error.h" diff --git a/hw/display/virtio-vga.c b/hw/display/virtio-vga.c index e5227fa..cc6e66e 100644 --- a/hw/display/virtio-vga.c +++ b/hw/display/virtio-vga.c @@ -1,5 +1,6 @@ #include "qemu/osdep.h" #include "hw/pci/pci.h" +#include "hw/qdev-properties.h" #include "hw/virtio/virtio-gpu.h" #include "qapi/error.h" #include "qemu/module.h" diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index f0b136e..23dc891 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -30,6 +30,7 @@ #include "trace.h" #include "ui/vnc.h" #include "hw/pci/pci.h" +#include "hw/qdev-properties.h" #include "migration/vmstate.h" #undef VERBOSE -- cgit v1.1