From 650d103d3ea959212f826acb9d3fe80cf30e347b Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 12 Aug 2019 07:23:48 +0200 Subject: Include hw/hw.h exactly where needed MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In my "build everything" tree, changing hw/hw.h triggers a recompile of some 2600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). The previous commits have left only the declaration of hw_error() in hw/hw.h. This permits dropping most of its inclusions. Touching it now recompiles less than 200 objects. Signed-off-by: Markus Armbruster Reviewed-by: Alistair Francis Message-Id: <20190812052359.30071-19-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé --- hw/char/debugcon.c | 1 - hw/char/digic-uart.c | 1 - hw/char/escc.c | 1 - hw/char/lm32_juart.c | 1 - hw/char/lm32_uart.c | 1 - hw/char/mcf_uart.c | 1 - hw/char/milkymist-uart.c | 1 - hw/char/omap_uart.c | 1 - hw/char/parallel.c | 1 - hw/char/sh_serial.c | 1 - hw/char/xen_console.c | 1 - hw/char/xilinx_uartlite.c | 1 + 12 files changed, 1 insertion(+), 11 deletions(-) (limited to 'hw/char') diff --git a/hw/char/debugcon.c b/hw/char/debugcon.c index e1b6d11..b38d828 100644 --- a/hw/char/debugcon.c +++ b/hw/char/debugcon.c @@ -27,7 +27,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/module.h" -#include "hw/hw.h" #include "chardev/char-fe.h" #include "hw/isa/isa.h" diff --git a/hw/char/digic-uart.c b/hw/char/digic-uart.c index 79ea922..cc50167 100644 --- a/hw/char/digic-uart.c +++ b/hw/char/digic-uart.c @@ -27,7 +27,6 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/sysbus.h" #include "migration/vmstate.h" #include "chardev/char-fe.h" diff --git a/hw/char/escc.c b/hw/char/escc.c index 404002b..35c6952 100644 --- a/hw/char/escc.c +++ b/hw/char/escc.c @@ -23,7 +23,6 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/irq.h" #include "hw/sysbus.h" #include "migration/vmstate.h" diff --git a/hw/char/lm32_juart.c b/hw/char/lm32_juart.c index f4488fa..69dd7ac 100644 --- a/hw/char/lm32_juart.c +++ b/hw/char/lm32_juart.c @@ -18,7 +18,6 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/sysbus.h" #include "migration/vmstate.h" #include "qemu/module.h" diff --git a/hw/char/lm32_uart.c b/hw/char/lm32_uart.c index 4b3215f..00832fb 100644 --- a/hw/char/lm32_uart.c +++ b/hw/char/lm32_uart.c @@ -23,7 +23,6 @@ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/irq.h" #include "hw/sysbus.h" #include "migration/vmstate.h" diff --git a/hw/char/mcf_uart.c b/hw/char/mcf_uart.c index c403a1f..1712b22 100644 --- a/hw/char/mcf_uart.c +++ b/hw/char/mcf_uart.c @@ -7,7 +7,6 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/irq.h" #include "hw/sysbus.h" #include "qemu/module.h" diff --git a/hw/char/milkymist-uart.c b/hw/char/milkymist-uart.c index 53c1ca7..e90f84d 100644 --- a/hw/char/milkymist-uart.c +++ b/hw/char/milkymist-uart.c @@ -22,7 +22,6 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/irq.h" #include "hw/sysbus.h" #include "migration/vmstate.h" diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c index b3bb1cf..13e4f43 100644 --- a/hw/char/omap_uart.c +++ b/hw/char/omap_uart.c @@ -19,7 +19,6 @@ */ #include "qemu/osdep.h" #include "chardev/char.h" -#include "hw/hw.h" #include "hw/arm/omap.h" #include "hw/char/serial.h" #include "exec/address-spaces.h" diff --git a/hw/char/parallel.c b/hw/char/parallel.c index 1798fd0..3980eb5 100644 --- a/hw/char/parallel.c +++ b/hw/char/parallel.c @@ -26,7 +26,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qemu/module.h" -#include "hw/hw.h" #include "chardev/char-parallel.h" #include "chardev/char-fe.h" #include "hw/irq.h" diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c index 7a40aa9..07dc16b 100644 --- a/hw/char/sh_serial.c +++ b/hw/char/sh_serial.c @@ -26,7 +26,6 @@ */ #include "qemu/osdep.h" -#include "hw/hw.h" #include "hw/irq.h" #include "hw/sh4/sh.h" #include "chardev/char-fe.h" diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c index 47e1092..8cc9328 100644 --- a/hw/char/xen_console.c +++ b/hw/char/xen_console.c @@ -24,7 +24,6 @@ #include #include "qapi/error.h" -#include "hw/hw.h" #include "chardev/char-fe.h" #include "hw/xen/xen-legacy-backend.h" diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartlite.c index 250eed9..fa7451f 100644 --- a/hw/char/xilinx_uartlite.c +++ b/hw/char/xilinx_uartlite.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "hw/hw.h" #include "hw/irq.h" #include "hw/sysbus.h" #include "qemu/module.h" -- cgit v1.1