From 71e8a915855857e0d45b322826778516cc3e3055 Mon Sep 17 00:00:00 2001 From: Markus Armbruster Date: Mon, 12 Aug 2019 07:23:38 +0200 Subject: Include sysemu/reset.h a lot less MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In my "build everything" tree, changing sysemu/reset.h triggers a recompile of some 2600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). The main culprit is hw/hw.h, which supposedly includes it for convenience. Include sysemu/reset.h only where it's needed. Touching it now recompiles less than 200 objects. Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Tested-by: Philippe Mathieu-Daudé Message-Id: <20190812052359.30071-9-armbru@redhat.com> --- hw/acpi/ich9.c | 2 ++ hw/acpi/piix4.c | 2 ++ hw/acpi/vmgenid.c | 1 + 3 files changed, 5 insertions(+) (limited to 'hw/acpi') diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index e53dfe1..b4d987c 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -23,6 +23,7 @@ * Contributions after 2012-01-13 are licensed under the terms of the * GNU GPL, version 2 or (at your option) any later version. */ + #include "qemu/osdep.h" #include "hw/hw.h" #include "qapi/error.h" @@ -30,6 +31,7 @@ #include "hw/i386/pc.h" #include "hw/pci/pci.h" #include "qemu/timer.h" +#include "sysemu/reset.h" #include "sysemu/sysemu.h" #include "hw/acpi/acpi.h" #include "hw/acpi/tco.h" diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index ec4e186..a59e58d 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -18,6 +18,7 @@ * Contributions after 2012-01-13 are licensed under the terms of the * GNU GPL, version 2 or (at your option) any later version. */ + #include "qemu/osdep.h" #include "hw/hw.h" #include "hw/i386/pc.h" @@ -25,6 +26,7 @@ #include "hw/i2c/pm_smbus.h" #include "hw/pci/pci.h" #include "hw/acpi/acpi.h" +#include "sysemu/reset.h" #include "sysemu/sysemu.h" #include "qapi/error.h" #include "qemu/range.h" diff --git a/hw/acpi/vmgenid.c b/hw/acpi/vmgenid.c index b891df3..ed92ccc 100644 --- a/hw/acpi/vmgenid.c +++ b/hw/acpi/vmgenid.c @@ -18,6 +18,7 @@ #include "hw/acpi/aml-build.h" #include "hw/acpi/vmgenid.h" #include "hw/nvram/fw_cfg.h" +#include "sysemu/reset.h" #include "sysemu/sysemu.h" void vmgenid_build_acpi(VmGenIdState *vms, GArray *table_data, GArray *guid, -- cgit v1.1