From f160a5b25b33b69b089815cfd435aa3199497984 Mon Sep 17 00:00:00 2001 From: Dinah Baum Date: Tue, 21 Feb 2023 06:06:30 -0500 Subject: configure: Add 'mkdir build' check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit QEMU configure script goes into an infinite error printing loop when in read only directory due to 'build' dir never being created. Checking if 'mkdir dir' succeeds prevents this error. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/321 Reviewed-by: Peter Maydell Signed-off-by: Dinah Baum Message-Id: <20230221110631.4142-1-dinahbaum123@gmail.com> Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé [thuth: Remove second "touch $MARKER"] Signed-off-by: Thomas Huth --- configure | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'configure') diff --git a/configure b/configure index cf6db3d..dccb5d4 100755 --- a/configure +++ b/configure @@ -31,8 +31,12 @@ then fi fi - mkdir build - touch $MARKER + if ! mkdir build || ! touch $MARKER + then + echo "ERROR: Could not create ./build directory. Check the permissions on" + echo "your source directory, or try doing an out-of-tree build." + exit 1 + fi cat > GNUmakefile <<'EOF' # This file is auto-generated by configure to support in-source tree -- cgit v1.1